Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner doesn't show on https://v6.fakerjs.dev/ and https://v7.fakerjs.dev/ #1497

Open
9 of 10 tasks
matthewmayer opened this issue Oct 29, 2022 · 2 comments
Open
9 of 10 tasks
Assignees
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@matthewmayer
Copy link
Contributor

Pre-Checks

Describe the bug

it looks like #1487 was supposed to show a banner "These docs are of an old version" on https://v6.fakerjs.dev/ however no banner is shown. Does this need to be backported?

Minimal reproduction code

No response

Additional Context

No response

Environment Info

n/a

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

npm

@matthewmayer matthewmayer added c: bug Something isn't working s: pending triage Pending Triage labels Oct 29, 2022
@Shinigami92
Copy link
Member

Does this need to be backported?

Yes, we have special branches:

We would need to open a PR to backport stuff from next to v7 and so on.

@Shinigami92 Shinigami92 removed the c: bug Something isn't working label Oct 29, 2022
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Oct 29, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Oct 29, 2022

Please backport it to v7 and v6. There is no need to port it to the v8 branch as it will be updated on release.

@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: pending triage Pending Triage labels Oct 29, 2022
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Oct 29, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Oct 29, 2022
@matthewmayer matthewmayer changed the title Banner doesn't show on https://v6.fakerjs.dev/ Banner doesn't show on https://v6.fakerjs.dev/ and https://v7.fakerjs.dev/ May 26, 2023
matthewmayer added a commit to matthewmayer/faker that referenced this issue May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Todo
Development

No branches or pull requests

3 participants