Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate vehicle registration number in SG context #3396

Open
clement7903 opened this issue Feb 8, 2025 · 4 comments
Open

Generate vehicle registration number in SG context #3396

clement7903 opened this issue Feb 8, 2025 · 4 comments
Labels
c: feature Request for new feature m: vehicle Something is referring to the vehicle module s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature

Comments

@clement7903
Copy link

Clear and concise description of the problem

As a developer using faker i want to generate vehicle registration number (Vehicle Registration Mark - VRM) in Singapore's context so that there is a more accurate and realistic local representation for Singapore's vehicle registration number

Suggested solution

  • Add new locale en_SG
  • Add new vrm() function which returns the appropriate vehicle registration number (Vehicle Registration Mark - VRM)

Alternative

No response

Additional context

No response

@clement7903 clement7903 added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@matthewmayer
Copy link
Contributor

matthewmayer commented Feb 8, 2025

Ruby has https://www.rubydoc.info/gems/faker/Faker%2FVehicle.license_plate for comparison

@matthewmayer
Copy link
Contributor

matthewmayer commented Feb 8, 2025

  • I think en_SG locale is a good idea
  • i think a faker.vehicle.vrm() (or licensePlate(), etc) is a good idea
  • i think the only issue will be with the checksum - we don't have a generic way to do a checksum calculation within a string provided by faker.helpers.fake, and i think there might be some resistance to adding additional custom code for a method if its only used in a single locale (versus say the Luhn checksum code used for faker.finance.creditCardNumber() which is used in all locales)

@matthewmayer matthewmayer added the m: vehicle Something is referring to the vehicle module label Feb 8, 2025
@ST-DDT
Copy link
Member

ST-DDT commented Feb 8, 2025

  • i think the only issue will be with the checksum - we don't have a generic way to do a checksum calculation within a string provided by faker.helpers.fake, and i think there might be some resistance to adding additional custom code for a method if its only used in a single locale (versus say the Luhn checksum code used for faker.finance.creditCardNumber() which is used in all locales)

This could be solved via:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: vehicle Something is referring to the vehicle module s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature
Projects
None yet
Development

No branches or pull requests

3 participants