Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp things-advanced (WSGI/ASGI) examples #2309

Open
vytas7 opened this issue Aug 28, 2024 · 5 comments
Open

Revamp things-advanced (WSGI/ASGI) examples #2309

vytas7 opened this issue Aug 28, 2024 · 5 comments
Labels
documentation good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance
Milestone

Comments

@vytas7
Copy link
Member

vytas7 commented Aug 28, 2024

We ought to showcase media handling in these instead of manually wrangling (de-)serialization. It is fine to show what is possible, but the emphasis should still be on media.

Revise App vs API usage: Useful for debugging problems in your API; ➡️ Useful for debugging problems in your App;.

Also check what's going on with the missing Content-Length in the ASGI variant, it looks like the proposed middleware doesn't handle it particularly well.

@vytas7 vytas7 added this to the Version 4.0 milestone Aug 28, 2024
@vytas7 vytas7 added documentation good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance labels Aug 28, 2024
@vytas7 vytas7 modified the milestones: Version 4.0, Version 4.1 Oct 5, 2024
@abdalahsalah
Copy link

can you assign me for this issue and tell me what is the related part of the repo can i change in @vytas7
and thank you !

@vytas7
Copy link
Member Author

vytas7 commented Feb 9, 2025

Hi @abdalahsalah!
We don't really "assign" in any special way, your comment here is normally enough for us and others to know you are working on this issue. I can remove the relevant label though.

You need to change README.rst and examples/things_advanced(_asgi)?.py. it would be nice to deduplicate or at least add a CI check they are in sync, but it is outside of scope for this issue.

@vytas7 vytas7 removed the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label Feb 9, 2025
@abdalahsalah
Copy link

Hi @vytas7 ,

Thank you for clarifying how assignments work here. I’ll go ahead and start working on this new issue.

Regarding the two files you mentioned (README.rst and examples/things_advanced(_asgi)?.py), could you please provide more details on the changes expected? Specifically.

@abdalahsalah
Copy link

@vytas7 ?

@vytas7
Copy link
Member Author

vytas7 commented Feb 10, 2025

Hi again, it is not two files, but three files: README.rst, examples/things_advanced.py, and examples/things_advanced_asgi.py.

I believe the issue's description explains what to do, I'm not sure if I can be more specific without actually making the changes. Maybe you could start running these files yourself to get familiar with what they do as a starting point?
To summarize the description, we want to better showcase standard media handling out of the box (see also req.get_media() and resp.media = ...`).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance
Projects
None yet
Development

No branches or pull requests

2 participants