Skip to content

feat(rust-workflow): Support the private registry #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tlater-famedly
Copy link
Contributor

@tlater-famedly tlater-famedly commented Jan 23, 2025

Fixes #35

@tlater-famedly tlater-famedly requested a review from a team as a code owner January 23, 2025 06:41
@tlater-famedly tlater-famedly force-pushed the tlater/registry-deps branch 3 times, most recently from baa183f to 201fb1a Compare January 23, 2025 06:51
@tlater-famedly tlater-famedly changed the title feat(rust-workflow): Support the private registry WIP: feat(rust-workflow): Support the private registry Jan 23, 2025
@tlater-famedly
Copy link
Contributor Author

The tests fail, but note that rust-workflow uses @main to figure out which version of the action to use, so this probably will work once merged.

Wish this wasn't all such a house of cards...

@tlater-famedly tlater-famedly changed the title WIP: feat(rust-workflow): Support the private registry feat(rust-workflow): Support the private registry Jan 23, 2025
emgrav
emgrav previously approved these changes Feb 4, 2025
@tlater-famedly
Copy link
Contributor Author

tlater-famedly commented Feb 4, 2025

I've been working on making this repository not dependent on @main, so while all our CI is hit by the artifactv4 migration "outage" I'd like to wait with merging this until that is done; or at least, another day or two.

#44 also already contains a fix for the time being, so a review of that would unblock running the tests here ;)

emgrav
emgrav previously approved these changes Feb 10, 2025
@tlater-famedly
Copy link
Contributor Author

Right, we can't add this test. The functionality is working in practice, but we can't access the private SSH key in this repo because it is public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add private registry login to rust workflow
2 participants