Module causes synapse to fail to start

[emgrav]

Synapse fails to initialize the module, which in turn causes synapse to fail to start. At first glance, this loks to be related to this change.

Synapse logs below:

2024-04-29 07:12:20,084 - synapse.app.homeserver - 179 - INFO - sentinel - Running
2024-04-29 07:12:20,085 - synapse.app.homeserver - 36 - INFO - sentinel - Set file limit to: 1048576
2024-04-29 07:12:20,086 - synapse.handlers.deactivate_account - 240 - INFO - user_parter_loop-0 - Starting user parter
2024-04-29 07:12:20,087 - synapse.handlers.auth - 1893 - ERROR - sentinel - Error while initializing <class 'synapse_token_authenticator.token_authenticator.TokenAuthenticator'>: TokenAuthenticator.__init__() got an unexpected keyword argument 'account_handler'
2024-04-29 07:12:20,087 - synapse.app._base - 273 - CRITICAL - sentinel - Error during startup
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/synapse/app/_base.py", line 258, in wrapper
    await cb(*args, **kwargs)
  File "/usr/local/lib/python3.11/site-packages/synapse/app/homeserver.py", line 370, in start
    await _base.start(hs)
  File "/usr/local/lib/python3.11/site-packages/synapse/app/_base.py", line 588, in start
    load_legacy_password_auth_providers(hs)
  File "/usr/local/lib/python3.11/site-packages/synapse/handlers/auth.py", line 1880, in load_legacy_password_auth_providers
    load_single_legacy_password_auth_provider(
  File "/usr/local/lib/python3.11/site-packages/synapse/handlers/auth.py", line 1891, in load_single_legacy_password_auth_provider
    provider = module(config=config, account_handler=api)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: TokenAuthenticator.__init__() got an unexpected keyword argument 'account_handler'
Error during startup:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/synapse/app/_base.py", line 258, in wrapper
    await cb(*args, **kwargs)
  File "/usr/local/lib/python3.11/site-packages/synapse/app/homeserver.py", line 370, in start
    await _base.start(hs)
  File "/usr/local/lib/python3.11/site-packages/synapse/app/_base.py", line 588, in start
    load_legacy_password_auth_providers(hs)
  File "/usr/local/lib/python3.11/site-packages/synapse/handlers/auth.py", line 1880, in load_legacy_password_auth_providers
    load_single_legacy_password_auth_provider(
  File "/usr/local/lib/python3.11/site-packages/synapse/handlers/auth.py", line 1891, in load_single_legacy_password_auth_provider
    provider = module(config=config, account_handler=api)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: TokenAuthenticator.__init__() got an unexpected keyword argument 'account_handler'

[emgrav]

This is a configuration issue. The linked change means the module needs to be loaded with the modules key rather than the password_providers key in the synapse configuration.