Merge pull request #3 from fastschema/refactor.update_error_messages_and_examples

refactor: update error messages and examples

Author: ngocphuongnb

README.md

@@ -429,7 +429,7 @@ func (ac *JsArrayToGoConverter[T]) convertToArray(jsArray *Array, jsLen int64) (
 	goArrayValue := reflect.New(ac.targetType).Elem()
 
 	if jsLen > int64(goArrayLen) {
-		return ac.sample, fmt.Errorf("DONE_JS array/set length (%d) exceeds Go array length (%d)", jsLen, goArrayLen)
+		return ac.sample, fmt.Errorf("JS array/set length (%d) exceeds Go array length (%d)", jsLen, goArrayLen)
 	}
 
 	for i := range jsLen {
@@ -474,7 +474,7 @@ func (ac *JsArrayToGoConverter[T]) convertViaJSON(jsArray *Array) (T, error) {
 
 	temp := reflect.New(ac.targetType).Interface()
 	if err = json.Unmarshal([]byte(jsonString), temp); err != nil {
-		return ac.sample, fmt.Errorf("DONE_can not unmarshal json: %w, input=%s", err, jsonString)
+		return ac.sample, fmt.Errorf("can not unmarshal json: %w, input=%s", err, jsonString)
 	}
 
 	arrayT, _ := reflect.ValueOf(temp).Elem().Interface().(T)
@@ -563,7 +563,7 @@ func IsTypedArray(input *Value) bool {
 // processTempValue validates if temp is a valid result for the given T type.
 func processTempValue[T any](prefix string, temp any, err error, samples ...T) (v T, _ error) {
 	if err != nil {
-		return v, fmt.Errorf("DONE_[%s] %w", prefix, err)
+		return v, fmt.Errorf("[%s] %w", prefix, err)
 	}
 
 	// Handle interface{} target types by accepting any converted value
@@ -685,7 +685,7 @@ func StringToNumeric(s string, targetType reflect.Type) (any, error) {
 		}
 	}
 
-	return nil, fmt.Errorf("DONE_cannot convert JS string %q to %s", s, targetType.String())
+	return nil, fmt.Errorf("cannot convert JS string %q to %s", s, targetType.String())
 }
 
 func createGoObjectTarget[T any](input ObjectOrMap, samples ...T) (

common.go

@@ -111,7 +111,7 @@ func newInvalidJsInputErr(kind string, input *Value) (err error) {
 		detail = fmt.Sprintf("(JSONStringify failed: %v), (.String()) %s", err, input.String())
 	}
 
-	return fmt.Errorf("DONE_expected JS %s, got %s=%s", kind, input.Type(), detail)
+	return fmt.Errorf("expected JS %s, got %s=%s", kind, input.Type(), detail)
 }
 
 func newJsStringifyErr(kind string, err error) error {

errors.go

@@ -13,7 +13,7 @@ func FuncToJS(c *Context, v any) (_ *Value, err error) {
 
 	defer func() {
 		if err != nil {
-			err = fmt.Errorf("DONE_[FuncToJS] %w", err)
+			err = fmt.Errorf("[FuncToJS] %w", err)
 		}
 	}()
 
@@ -66,11 +66,11 @@ func VerifyGoFunc(fnType reflect.Type) error {
 	numOut := fnType.NumOut()
 
 	if numOut > MaxGoFuncReturnValues {
-		return fmt.Errorf("DONE_expected 0-2 return values, got '%s'", signature)
+		return fmt.Errorf("expected 0-2 return values, got '%s'", signature)
 	}
 
 	if numOut == MaxGoFuncReturnValues && !IsImplementError(fnType.Out(1)) {
-		return fmt.Errorf("DONE_expected second return to be error, got '%s'", signature)
+		return fmt.Errorf("expected second return to be error, got '%s'", signature)
 	}
 
 	if numOut >= 1 {
@@ -83,7 +83,7 @@ func VerifyGoFunc(fnType reflect.Type) error {
 	for i := range fnType.NumIn() {
 		err := IsConvertibleToJs(fnType.In(i), make(map[reflect.Type]bool), "func param")
 		if err != nil {
-			return fmt.Errorf("DONE_parameter %d error: %w", i, err)
+			return fmt.Errorf("parameter %d error: %w", i, err)
 		}
 	}
 

functojs.go

@@ -400,7 +400,7 @@ func setFieldWithJSONUnmarshaler(
 	}
 
 	if err := unmarshaler.UnmarshalJSON([]byte(jsonStr)); err != nil {
-		return fmt.Errorf("DONE_cannot unmarshal json: %w, %s=%s", err, fieldInfo.field.Name, jsonStr)
+		return fmt.Errorf("cannot unmarshal json: %w, %s=%s", err, fieldInfo.field.Name, jsonStr)
 	}
 
 	fieldValue.Set(unmarshalerValue)
@@ -473,7 +473,7 @@ func jsObjectToGo[T any](
 	}
 
 	if err = json.Unmarshal([]byte(jsonString), tempPtr); err != nil {
-		err = fmt.Errorf("DONE_can not unmarshal json: %w, input=%s", err, jsonString)
+		err = fmt.Errorf("can not unmarshal json: %w, input=%s", err, jsonString)
 
 		return processTempValue("JsObjectToGo", nil, err, sample)
 	}
@@ -546,7 +546,7 @@ func createJsFunctionHandler(
 	jsResult, err := ctx.Invoke(input, ctx.Global(), jsArgs...)
 	if err != nil {
 		results[len(results)-1] = reflect.ValueOf(
-			fmt.Errorf("DONE_JS function execution failed: %w", err),
+			fmt.Errorf("JS function execution failed: %w", err),
 		)
 
 		return results
@@ -644,7 +644,7 @@ func handleJsFunctionResult(
 	goResult, err := jsValueToGo[any](tracker, jsResult)
 	if err != nil {
 		results[len(results)-1] = reflect.ValueOf(
-			fmt.Errorf("DONE_failed to convert JS function result '%s' to Go: %w", jsResult.Type(), err),
+			fmt.Errorf("failed to convert JS function result '%s' to Go: %w", jsResult.Type(), err),
 		)
 
 		return results
@@ -656,7 +656,7 @@ func handleJsFunctionResult(
 	targetType := fnType.Out(0)
 	if !goResultValue.CanConvert(targetType) {
 		results[len(results)-1] = reflect.ValueOf(
-			fmt.Errorf("DONE_failed to convert JS function return value from %T (%v) to %s", goResult, goResult, targetType),
+			fmt.Errorf("failed to convert JS function return value from %T (%v) to %s", goResult, goResult, targetType),
 		)
 
 		return results

jstogo.go

@@ -215,7 +215,7 @@ func getRuntimeOption(registry *ProxyRegistry, options ...*Option) (option *Opti
 
 	if option.CWD == "" {
 		if option.CWD, err = os.Getwd(); err != nil {
-			return nil, fmt.Errorf("DONE_cannot get current working directory: %w", err)
+			return nil, fmt.Errorf("cannot get current working directory: %w", err)
 		}
 	}
 

options.go

@@ -14,10 +14,10 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func setupTestContext(t *testing.T) (*qjs.Runtime, *qjs.Context) {
+func setupTestContext(_ *testing.T) (*qjs.Runtime, *qjs.Context) {
 	runtime := must(qjs.New())
 	ctx := runtime.Context()
-	t.Cleanup(runtime.Close)
+	// t.Cleanup(runtime.Close)
 	return runtime, ctx
 }
 

testutils_test.go

@@ -306,7 +306,7 @@ func (v *Value) Invoke(fname string, args ...*Value) (*Value, error) {
 	defer fn.Free()
 
 	if !fn.IsFunction() {
-		return v.NewUndefined(), fmt.Errorf("DONE_JS property '%s' is not a function", fname)
+		return v.NewUndefined(), fmt.Errorf("JS property '%s' is not a function", fname)
 	}
 
 	argc, argvPtr := createJsCallArgs(v.context, args...)
@@ -560,7 +560,7 @@ func (v *Value) JSONStringify() (_ string, err error) {
 	defer func() {
 		r := AnyToError(recover())
 		if r != nil {
-			err = fmt.Errorf("DONE_failed to stringify JS value: %w", r)
+			err = fmt.Errorf("failed to stringify JS value: %w", r)
 		}
 	}()