From d87b817c49b5f77a62693a94e7b10e5b461235a5 Mon Sep 17 00:00:00 2001 From: Arun Date: Sun, 23 Sep 2018 13:02:07 -0700 Subject: [PATCH 1/3] Change shuffle to do sampling without replacement `numpy.random.randint` does sampling with replacement. Change to `numpy.random.choice` and set `replace=False` for sampling without replacement. --- 6.3-advanced-usage-of-recurrent-neural-networks.ipynb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/6.3-advanced-usage-of-recurrent-neural-networks.ipynb b/6.3-advanced-usage-of-recurrent-neural-networks.ipynb index 5de9767b00..bc5f270404 100644 --- a/6.3-advanced-usage-of-recurrent-neural-networks.ipynb +++ b/6.3-advanced-usage-of-recurrent-neural-networks.ipynb @@ -1157,8 +1157,7 @@ " i = min_index + lookback\n", " while 1:\n", " if shuffle:\n", - " rows = np.random.randint(\n", - " min_index + lookback, max_index, size=batch_size)\n", + " rows = np.random.choice(range(min_index + lookback, max_index), size=batch_size, replace=False)\n" " else:\n", " if i + batch_size >= max_index:\n", " i = min_index + lookback\n", From ee766176da7e886748b0afce16fe16851f8ed499 Mon Sep 17 00:00:00 2001 From: Arun Date: Sun, 23 Sep 2018 13:03:22 -0700 Subject: [PATCH 2/3] Add comma Pull req on IPython NB! --- 6.3-advanced-usage-of-recurrent-neural-networks.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/6.3-advanced-usage-of-recurrent-neural-networks.ipynb b/6.3-advanced-usage-of-recurrent-neural-networks.ipynb index bc5f270404..7fd5772673 100644 --- a/6.3-advanced-usage-of-recurrent-neural-networks.ipynb +++ b/6.3-advanced-usage-of-recurrent-neural-networks.ipynb @@ -1157,7 +1157,7 @@ " i = min_index + lookback\n", " while 1:\n", " if shuffle:\n", - " rows = np.random.choice(range(min_index + lookback, max_index), size=batch_size, replace=False)\n" + " rows = np.random.choice(range(min_index + lookback, max_index), size=batch_size, replace=False)\n", " else:\n", " if i + batch_size >= max_index:\n", " i = min_index + lookback\n", From f981c07b4b4d4ec173e048843ce4e58b79c6ac35 Mon Sep 17 00:00:00 2001 From: Arun Date: Sun, 23 Sep 2018 13:08:08 -0700 Subject: [PATCH 3/3] Change shuffle to do sampling without replacement --- 6.3-advanced-usage-of-recurrent-neural-networks.ipynb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/6.3-advanced-usage-of-recurrent-neural-networks.ipynb b/6.3-advanced-usage-of-recurrent-neural-networks.ipynb index 7fd5772673..8088517799 100644 --- a/6.3-advanced-usage-of-recurrent-neural-networks.ipynb +++ b/6.3-advanced-usage-of-recurrent-neural-networks.ipynb @@ -285,8 +285,7 @@ " i = min_index + lookback\n", " while 1:\n", " if shuffle:\n", - " rows = np.random.randint(\n", - " min_index + lookback, max_index, size=batch_size)\n", + " rows = np.random.choice(range(min_index + lookback, max_index), size=batch_size, replace=False)\n", " else:\n", " if i + batch_size >= max_index:\n", " i = min_index + lookback\n",