Skip to content

Latest commit

 

History

History
30 lines (17 loc) · 1.15 KB

pull_request_template.md

File metadata and controls

30 lines (17 loc) · 1.15 KB

[Bug] Step by step walkthrough of how to reproduce (console/UI/etc). When and how did the problem begin?

Iterate through the changes in this PR. Why did you implement them this way?

Was anything tried that didn't work? Anything that reviewers should pay attention to or difficult or tricky that should be explained?

Does anything special need to happen for deployment?

"Ready For Review" checklist

These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.

  • PR title accurately summarizes changes
  • New tests were added for isolated methods or new endpoints
  • I opened an issue for any logical followups
  • If this fixes a bug, "Fixes #XXX" is either the very first or very last line of the description.

Before code review and after additional commits during review.

  • Update title and description to account for additional changes
  • All tests green
  • Migrations were tested locally and do the right thing
  • Booted up the branch locally, exercised any new code
  • Percy changes are purposeful or explained
  • Css changes are happy on mobile (via Percy is ok)