add flag key to evaluation detail

Author: deleteLater

src/FeatBit.ServerSdk/Evaluation/EvalDetail.cs

@@ -2,6 +2,11 @@ namespace FeatBit.Sdk.Server.Evaluation
 {
     public class EvalDetail<TValue>
     {
+        /// <summary>
+        /// The key of the flag that was evaluated.
+        /// </summary>
+        public string Key { get; set; }
+
         /// <summary>
         /// An enum indicating the category of the reason.
         /// </summary>
@@ -21,11 +26,13 @@ public class EvalDetail<TValue>
         /// <summary>
         /// Constructs a new EvalDetail instance.
         /// </summary>
+        /// <param name="key">the flag key</param>
         /// <param name="kind">the reason kind</param>
         /// <param name="reason">the evaluation reason</param>
         /// <param name="value">the flag value</param>
-        public EvalDetail(ReasonKind kind, string reason, TValue value)
+        public EvalDetail(string key, ReasonKind kind, string reason, TValue value)
         {
+            Key = key;
             Kind = kind;
             Reason = reason;
             Value = value;

src/FeatBit.ServerSdk/FbClient.cs

@@ -244,8 +244,11 @@ public EvalDetail<string>[] GetAllVariations(FbUser user)
         {
             var results = _store
                 .Find<FeatureFlag>(x => x.StoreKey.StartsWith(StoreKeys.FlagPrefix))
-                .Select(flag => _evaluator.Evaluate(flag, user).evalResult)
-                .Select(x => new EvalDetail<string>(x.Kind, x.Reason, x.Value))
+                .Select(flag =>
+                {
+                    var evalResult = _evaluator.Evaluate(flag, user).evalResult;
+                    return new EvalDetail<string>(flag.Key, evalResult.Kind, evalResult.Reason, evalResult.Value);
+                })
                 .ToArray();
 
             return results;
@@ -285,7 +288,7 @@ private EvalDetail<TValue> EvaluateCore<TValue>(
             if (!Initialized)
             {
                 // Flag evaluation before client initialized; always returning default value
-                return new EvalDetail<TValue>(ReasonKind.ClientNotReady, "client not ready", defaultValue);
+                return new EvalDetail<TValue>(key, ReasonKind.ClientNotReady, "client not ready", defaultValue);
             }
 
             var ctx = new EvaluationContext
@@ -298,16 +301,16 @@ private EvalDetail<TValue> EvaluateCore<TValue>(
             if (evalResult.Kind == ReasonKind.Error)
             {
                 // error happened when evaluate flag, return default value 
-                return new EvalDetail<TValue>(evalResult.Kind, evalResult.Reason, defaultValue);
+                return new EvalDetail<TValue>(key, evalResult.Kind, evalResult.Reason, defaultValue);
             }
 
             // record evaluation event
             _eventProcessor.Record(evalEvent);
 
             return converter(evalResult.Value, out var typedValue)
-                ? new EvalDetail<TValue>(evalResult.Kind, evalResult.Reason, typedValue)
+                ? new EvalDetail<TValue>(key, evalResult.Kind, evalResult.Reason, typedValue)
                 // type mismatch, return default value
-                : new EvalDetail<TValue>(ReasonKind.WrongType, "type mismatch", defaultValue);
+                : new EvalDetail<TValue>(key, ReasonKind.WrongType, "type mismatch", defaultValue);
         }
     }
 }

tests/FeatBit.ServerSdk.Tests/FbClientTests.cs

@@ -60,6 +60,7 @@ public void GetVariationDetail()
 
         var user = FbUser.Builder("u1").Build();
         var variationDetail = client.BoolVariationDetail("returns-true", user);
+        Assert.Equal("returns-true", variationDetail.Key);
         Assert.True(variationDetail.Value);
         Assert.Equal(ReasonKind.Fallthrough, variationDetail.Kind);
         Assert.Equal("fall through targets and rules", variationDetail.Reason);
@@ -77,6 +78,7 @@ public void GetAllVariations()
         Assert.Single(results);
 
         var result0 = results[0];
+        Assert.Equal("returns-true", result0.Key);
         Assert.Equal("true", result0.Value);
         Assert.Equal(ReasonKind.Fallthrough, result0.Kind);
         Assert.Equal("fall through targets and rules", result0.Reason);