Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript TEST SDK improvements #18

Open
IrinaSouth opened this issue Feb 27, 2021 · 1 comment
Open

Typescript TEST SDK improvements #18

IrinaSouth opened this issue Feb 27, 2021 · 1 comment
Assignees

Comments

@IrinaSouth
Copy link
Contributor

IrinaSouth commented Feb 27, 2021

  • When updating the value with the same "current value", e.g.
 const response = await featureUpdater.updateKey(name, new FeatureStateUpdate({
        lock: false,
        value: currentValue,
    }));

the API returns 202 and "false". However it should be "true" - because it was the successful update, despite it is the same value. Need to update the API yaml

  • When updating a JSON value, it seems that it doesn't check the object, so possibly need to check and "stringify" the value

  • When updating a boolean value - it should not accept strings or numbers

@rvowles
Copy link
Contributor

rvowles commented Feb 27, 2021

host in nodejs also needs to change to hostname

@IrinaSouth IrinaSouth transferred this issue from featurehub-io/featurehub Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants