Fix emoji import fail when shortcodes are in use

Fix #102

Author: dahlia

CHANGES.md

@@ -13,8 +13,12 @@ To be released.
  -  Fixed a bug where Hollo posts had included unintended extra line breaks
     on Iceshrimp.  [[#88]]
 
+ -  Fixed a bug where importing emojis from remote servers had failed when
+    some shortcodes were already in use.  [[102]]
+
 [#88]: https://github.com/fedify-dev/hollo/issues/88
 [#98]: https://github.com/fedify-dev/hollo/issues/98
+[#102]: https://github.com/fedify-dev/hollo/issues/102
 
 
 Version 0.4.4

src/pages/emojis.tsx

@@ -1,3 +1,4 @@
+import { getLogger } from "@logtape/logtape";
 import { desc, inArray, isNotNull, ne } from "drizzle-orm";
 import { Hono } from "hono";
 import mime from "mime";
@@ -7,6 +8,8 @@ import { loginRequired } from "../login";
 import { accounts, customEmojis, posts, reactions } from "../schema";
 import { disk, getAssetUrl } from "../storage";
 
+const logger = getLogger(["hollo", "pages", "emojis"]);
+
 const emojis = new Hono();
 
 emojis.use(loginRequired);
@@ -368,13 +371,16 @@ emojis.post("/import", async (c) => {
       ? (form.get("new")?.toString() ?? "")
       : null;
   const imports = form.getAll("import").map((i) => JSON.parse(i.toString()));
-  await db.insert(customEmojis).values(
-    imports.map(({ shortcode, url }) => ({
-      category,
-      shortcode,
-      url,
-    })),
-  );
+  for (const { shortcode, url } of imports) {
+    try {
+      await db.insert(customEmojis).values({ category, shortcode, url });
+    } catch (error) {
+      logger.error(
+        "Failed to import emoji {shortcode} to {category}: {error}",
+        { category, shortcode, error },
+      );
+    }
+  }
   return c.redirect("/emojis");
 });