[RFE] Please make this compatible with sources stored in the git repo with Git-LFS

[amessina]

Working toward integrating Forgejo with my long-running local Koji instance and I would sincerely appreciate if %autochangelog would work with SOURCES pulled in during git clone (with Git-LFS).

[sgallagher]

Could you be more specific? I’m not clear on what exactly this would look like? Can you please describe the behavior as you would expect to see it?

…

On Sat, Sep 6, 2025 at 1:47 PM Anthony Messina ***@***.***> wrote: *amessina* created an issue (fedora-infra/rpmautospec#337) <#337> Working toward integrating Forgejo with my long-running local Koji instance and I would sincerely appreciate if %autochangelog would work with SOURCES pulled in during git clone (with Git-LFS). — Reply to this email directly, view it on GitHub <#337>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFURY3BM2KXIX5VDE6ZW2L3RMM3TAVCNFSM6AAAAACFZW6RA6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGM4TANRQGA3DMNA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[amessina]

I'd like to use Forgejo, storing sources in the embedded Git-LFS (greatly simplifies things for my small instance). As it stands I've been using a slightly modified dist-git and fedpkg clone I call msspkg to override the lookaside.

As I've been reading on Fedora's work to use Forgejo, I haven't found any information on the storage you plan to use when you get to migrating src.fedoraproject.org/rpms/.

I've tried mock-rpmautospec as well to no avail.

In the interim, it looks like I'd need to update my clone of fedpkg-minimal to account for this, then do a git lfs fetch or something, but I don't know if the git repo url is passed with environment variables (in Koji's) allowed_scm.

[amessina]

After playing around a bit, I see that it is upping the changelog, but the top entry is now always:

* Sat Sep 06 2025 Unknown User <please-configure-git-user@example.com> - 1.0.0-7
- Uncommitted changes

and my most recent commit is just below that.

[sgallagher]

Right, that is telling you that you have uncommitted changes in your git checkout. I'm not really sure what you think is a bug here.

[amessina]

I'm not sure what you mean by that. I've added the files, committed, pushed to the "central" bar repository from where Koji SCM checks out (just like upstream Fedora).

The only thing I can think is since Koji doesn't seem to use git that can pull LFS (just the pointers), rpmautospec thinks that more needs to be done locally.

Unfortunately, rpmautospec is called prior to Koji's sources_cmd which I have set up to do a git lfs fetch and actually pull them down.

Is that what you mean? It still shouldn't affect the changelog. It also issues the same message locally after the LFS files are committed.

[amessina]

Steps to reproduce:

1. Create and enter directory "test"
2. Do git init and git branch -m rawhide
3. Add "test.spec" using %autorelease and %autochangelog functionality in the directory and do git add test.spec followed by git commit
4. Do rpmautospec generate-changelog and see a correct changelog
5. Do git lfs track "*tar.gz" which creates ".gitattributes"
6. Do git add .gitattributes followed by git commit
7. Do rpmautospec generate-changelog and see a correct changelog
8. Add an archive ending in .tar.gz, in my case "test.tar.gz"
9. Do git add test.tar.gz followed by git commit
10. 7. Do rpmautospec generate-changelog and see an incorrect changelog where the first entry reads:

* Thu Sep 11 2025 My My <me.my@example.org> - 0.1-4
- Uncommitted changes

Running (git-lfs-3.6.1-1.fc42.x86_64) git lfs env produces:

git-lfs/3.6.1 (GitHub; linux amd64; go 1.23.4)
git version 2.51.0

LocalWorkingDir=/home/me/test
LocalGitDir=/home/me/test/.git
LocalGitStorageDir=/home/me/test/.git
LocalMediaDir=/home/me/test/.git/lfs/objects
LocalReferenceDirs=
TempDir=/home/me/test/.git/lfs/tmp
ConcurrentTransfers=8
TusTransfers=false
BasicTransfersOnly=false
SkipDownloadErrors=false
FetchRecentAlways=false
FetchRecentRefsDays=7
FetchRecentCommitsDays=0
FetchRecentRefsIncludeRemotes=true
PruneOffsetDays=3
PruneVerifyRemoteAlways=false
PruneVerifyUnreachableAlways=false
PruneRemoteName=origin
LfsStorageDir=/home/me/test/.git/lfs
AccessDownload=none
AccessUpload=none
DownloadTransfers=basic,lfs-standalone-file,ssh
UploadTransfers=basic,lfs-standalone-file,ssh
GIT_EXEC_PATH=/usr/libexec/git-core
git config filter.lfs.process = "git-lfs filter-process"
git config filter.lfs.smudge = "git-lfs smudge -- %f"
git config filter.lfs.clean = "git-lfs clean -- %f"

Running (rpmautospec-0.8.1-11.fc42.noarch) rpmautospec --debug generate-changelog produces:

DEBUG:rpmautospec.pkg_history:===========================================================
DEBUG:rpmautospec.pkg_history:Extracting linear history snippets from branched history...
DEBUG:rpmautospec.pkg_history:===========================================================
DEBUG:rpmautospec.pkg_history:commit fe0be19: Add test.tar.gz
DEBUG:rpmautospec.pkg_history:Keep processing: commit fe0be1902685f8a2dd893241df261775a302f020
DEBUG:rpmautospec.pkg_history:  epoch_version: 0.1
DEBUG:rpmautospec.pkg_history:  child must continue: True
DEBUG:rpmautospec.pkg_history:  changelog changed: False
DEBUG:rpmautospec.pkg_history:  child changelog removed: None
DEBUG:rpmautospec.pkg_history:  our changelog removed: False
DEBUG:rpmautospec.pkg_history:  merge unresolvable: False
DEBUG:rpmautospec.pkg_history:  spec file present: True
DEBUG:rpmautospec.pkg_history:  child must continue (incoming): True
DEBUG:rpmautospec.pkg_history:  child must continue (outgoing): True
DEBUG:rpmautospec.pkg_history:  parent to follow: ae363c7
DEBUG:rpmautospec.pkg_history:commit ae363c7: Add .gitattributes to track *tar.gz with Git-LFS
DEBUG:rpmautospec.pkg_history:children_visitors_info[]['child_must_continue']: [True, True]
DEBUG:rpmautospec.pkg_history:Keep processing: commit ae363c7d265be49bc081ba4820eb4a521664a46d
DEBUG:rpmautospec.pkg_history:  epoch_version: 0.1
DEBUG:rpmautospec.pkg_history:  child must continue: True
DEBUG:rpmautospec.pkg_history:  changelog changed: False
DEBUG:rpmautospec.pkg_history:  child changelog removed: False
DEBUG:rpmautospec.pkg_history:  our changelog removed: False
DEBUG:rpmautospec.pkg_history:  merge unresolvable: False
DEBUG:rpmautospec.pkg_history:  spec file present: True
DEBUG:rpmautospec.pkg_history:  child must continue (incoming): True
DEBUG:rpmautospec.pkg_history:  child must continue (outgoing): True
DEBUG:rpmautospec.pkg_history:  parent to follow: 3431f80
DEBUG:rpmautospec.pkg_history:commit 3431f80: Initial commit - add test.spec
DEBUG:rpmautospec.pkg_history:children_visitors_info[]['child_must_continue']: [True, True]
DEBUG:rpmautospec.pkg_history:Keep processing: commit 3431f808f972b20bc586766278fa01bd290c3de2
DEBUG:rpmautospec.pkg_history:  epoch_version: 0.1
DEBUG:rpmautospec.pkg_history:  child must continue: False
DEBUG:rpmautospec.pkg_history:  changelog changed: False
DEBUG:rpmautospec.pkg_history:  child changelog removed: False
DEBUG:rpmautospec.pkg_history:  our changelog removed: False
DEBUG:rpmautospec.pkg_history:  merge unresolvable: False
DEBUG:rpmautospec.pkg_history:  spec file present: True
DEBUG:rpmautospec.pkg_history:  child must continue (incoming): True
DEBUG:rpmautospec.pkg_history:  child must continue (outgoing): True
DEBUG:rpmautospec.pkg_history:  no parents, bailing out
DEBUG:rpmautospec.pkg_history:=====================================
DEBUG:rpmautospec.pkg_history:Processing linear history snippets...
DEBUG:rpmautospec.pkg_history:=====================================
DEBUG:rpmautospec.pkg_history:Processing snippet fe0be19
DEBUG:rpmautospec.pkg_history:commit 3431f80: Initial commit - add test.spec
DEBUG:rpmautospec.pkg_history:  epoch_version: 0.1
DEBUG:rpmautospec.pkg_history:  parent rel numbers: 
DEBUG:rpmautospec.pkg_history:  release_number: 1
DEBUG:rpmautospec.pkg_history:  no parent to follow
DEBUG:rpmautospec.pkg_history:  skip_for_changelog: False
DEBUG:rpmautospec.pkg_history:commit ae363c7: Add .gitattributes to track *tar.gz with Git-LFS
DEBUG:rpmautospec.pkg_history:  3431f80: p in visited results: True
DEBUG:rpmautospec.pkg_history:  commit_coroutines[p] is None: False
DEBUG:rpmautospec.pkg_history:  epoch_version: 0.1
DEBUG:rpmautospec.pkg_history:  parent rel numbers: 1
DEBUG:rpmautospec.pkg_history:  release_number: 2
DEBUG:rpmautospec.pkg_history:  one parent: 3431f80
DEBUG:rpmautospec.pkg_history:  skip_for_changelog: False
DEBUG:rpmautospec.pkg_history:commit fe0be19: Add test.tar.gz
DEBUG:rpmautospec.pkg_history:  ae363c7: p in visited results: True
DEBUG:rpmautospec.pkg_history:  commit_coroutines[p] is None: False
DEBUG:rpmautospec.pkg_history:  epoch_version: 0.1
DEBUG:rpmautospec.pkg_history:  parent rel numbers: 2
DEBUG:rpmautospec.pkg_history:  release_number: 3
DEBUG:rpmautospec.pkg_history:  one parent: ae363c7
DEBUG:rpmautospec.pkg_history:  skip_for_changelog: False

Following is "test.spec"

Summary: Test rpmautospec with Git-LFS
Name: test
Version: 0.1
Release: %autorelease
License: GPLv3+
URL: https://example.org/test
Source: test.tar.gz
BuildArch: noarch

%description
%{summary}

%prep
%autosetup

%build

%install

%files
%{_sysconfdir}/test.spec

%changelog
%autochangelog

[amessina]

Wondering if the output above is useful to move forward with a resolution. The only difference I can see with the final commit in the output (commit fe0be19: Add test.tar.gz) is it contains

child changelog removed: None -- instead of all the other commits which produce child changelog removed: False

[nphilipp]

I’m currently on vacation, but want to look at this when I’m back.

[amessina]

No problem. Enjoy the time away.