Skip to content

Commit 17befe9

Browse files
committed
Fix source code viewer background color when using Dark Mode in Diffusion
Summary: This CSS fix replaces the hard coded white background value by the diff.background CSS variable. This is a proposal to address this issue but it may be a good idea to create a different CSS variable (for instance source.background) in order to avoid any potential side effect in the future. | Before | After | |---------|---------| |{F333617}|{F333618}| Fix : T15056 Test Plan: - Flush all Phorge caches - Sign in - Open a diffusion repository - Open any file - Check that viewer background color is consistent with the theme. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25396
1 parent a5d8b2d commit 17befe9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

resources/celerity/map.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
'rsrc/css/fuel/fuel-handle-list.css' => '2c4cbeca',
122122
'rsrc/css/fuel/fuel-map.css' => 'd6e31510',
123123
'rsrc/css/fuel/fuel-menu.css' => '21f5d199',
124-
'rsrc/css/layout/phabricator-source-code-view.css' => '49656486',
124+
'rsrc/css/layout/phabricator-source-code-view.css' => 'e382316a',
125125
'rsrc/css/phui/button/phui-button-bar.css' => 'a4aa75c4',
126126
'rsrc/css/phui/button/phui-button-simple.css' => '1ff278aa',
127127
'rsrc/css/phui/button/phui-button.css' => 'f9d0f9c8',
@@ -805,7 +805,7 @@
805805
'phabricator-search-results-css' => '9ea70ace',
806806
'phabricator-shaped-request' => '995f5102',
807807
'phabricator-slowvote-css' => '1694baed',
808-
'phabricator-source-code-view-css' => '49656486',
808+
'phabricator-source-code-view-css' => 'e382316a',
809809
'phabricator-standard-page-view' => 'e08c7462',
810810
'phabricator-textareautils' => 'f340a484',
811811
'phabricator-title' => '43bc9360',

webroot/rsrc/css/layout/phabricator-source-code-view.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
white-space: pre-wrap;
1717
padding: 2px 8px 1px;
1818
width: 100%;
19-
background: #ffffff;
19+
background: {$diff.background};
2020
}
2121

2222
.phabricator-source-line {

0 commit comments

Comments
 (0)