Skip to content

Commit 216d308

Browse files
committed
Fix Project Hovercard rendering @mention
Summary: Fix T15762. There's a complex interaction with project's AutoCapability requiring the membership info to be already loaded, and the Mention rule assuming any project is fully loaded before trying to check permissions. As far as I can tell, the "contextObject" is currently used only to make the mention handle gray if the mentioned user can't see it. Test Plan: Load a Project's hovercard that @mentions a user that can't see the project - no crash. Reviewers: aklapper, O1 Blessed Committers Reviewed By: aklapper, O1 Blessed Committers Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15762 Differential Revision: https://we.phorge.it/D25562
1 parent b1ae1b1 commit 216d308

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/applications/project/view/PhabricatorProjectCardView.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ protected function getTagContent() {
8080
$description = $description_field->getFieldValue();
8181
if (phutil_nonempty_string($description)) {
8282
$description = PhabricatorMarkupEngine::summarizeSentence($description);
83-
$description = id(new PHUIRemarkupView($viewer, $description))
84-
->setContextObject($project);
83+
$description = id(new PHUIRemarkupView($viewer, $description));
8584

8685
$description = phutil_tag(
8786
'div',

0 commit comments

Comments
 (0)