Skip to content

Commit 3f5fcdf

Browse files
committed
Fix icon background color when using Dark Mode
Summary: This CSS fix replaces the hard coded background gradient (white) value of icons when using Dark Mode. Now the "Choose User Icon" popup has visible icons. | Before | After | |---------|---------| |{F331622}|{F331623}| Ref T15056 Test Plan: - Flush all Phorge caches - Sign in - Go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode". - Go to user's profile, edit profile and click on Choose icon. - Check that now the icons in "Choose User Icon" are visible. - Do these steps for each user interface theme in order to check against regression. Reviewers: O1 Blessed Committers, Matthew, valerio.bozzolan Reviewed By: O1 Blessed Committers, Matthew, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15056 Differential Revision: https://we.phorge.it/D25384
1 parent 7040bd5 commit 3f5fcdf

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

resources/celerity/map.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
'rsrc/css/phui/phui-head-thing.css' => 'd7f293df',
161161
'rsrc/css/phui/phui-header-view.css' => '36c86a58',
162162
'rsrc/css/phui/phui-hovercard.css' => '39fd2e14',
163-
'rsrc/css/phui/phui-icon-set-selector.css' => '7aa5f3ec',
163+
'rsrc/css/phui/phui-icon-set-selector.css' => '19e0253b',
164164
'rsrc/css/phui/phui-icon.css' => '084ac612',
165165
'rsrc/css/phui/phui-image-mask.css' => '62c7f4d2',
166166
'rsrc/css/phui/phui-info-view.css' => 'a10a909b',
@@ -856,7 +856,7 @@
856856
'phui-hovercard' => '6199f752',
857857
'phui-hovercard-list' => 'de4b4919',
858858
'phui-hovercard-view-css' => '39fd2e14',
859-
'phui-icon-set-selector-css' => '7aa5f3ec',
859+
'phui-icon-set-selector-css' => '19e0253b',
860860
'phui-icon-view-css' => '084ac612',
861861
'phui-image-mask-css' => '62c7f4d2',
862862
'phui-info-view-css' => 'a10a909b',

webroot/rsrc/css/phui/phui-icon-set-selector.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
*/
44

55
button.icon-button {
6-
background-color: #F7F7F9;
7-
background-image: linear-gradient(to bottom, #ffffff, #f1f0f1);
6+
background-image: linear-gradient(to bottom,
7+
{$lightgreybackground}, {$greybackground});
88
border: 1px solid rgba({$alphablue},.2);
99
color: {$darkgreytext};
1010
position: relative;

0 commit comments

Comments
 (0)