Skip to content

Commit 40d10fb

Browse files
committed
Fix PHP 8.1 "strlen(null)" exception when custom select field configured
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter freebsd#1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:484] ``` Closes T15687 Test Plan: Unknown. Definitely requires having custom fields defined, then playing with creating tasks using forms which expose these fields and going to `/maniphest/query/all/`. See also D25487. Reviewers: O1 Blessed Committers, speck Reviewed By: O1 Blessed Committers, speck Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15687 Differential Revision: https://we.phorge.it/D25492
1 parent 49c3fe6 commit 40d10fb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ public function updateAbstractDocument(
481481
}
482482

483483
$field_value = $this->getFieldValue();
484-
if (strlen($field_value)) {
484+
if (($field_value !== null) && (strlen($field_value))) {
485485
$document->addField($field_key, $field_value);
486486
}
487487
}

0 commit comments

Comments
 (0)