Skip to content

Commit 94c0774

Browse files
committed
log deprecation events in Dark Console
Summary: `PhutilErrorHandler` already defines "DEPRECATED" error class, but it's not used. I plan to use it to report deprecation warnings. With this change, they will be shown in the Dark Console and in the error logs Ref T15554 This change on its own won't do anything, but is safe to land first. Test Plan: With D25387, pages that have deprecation warnings are now shown, and the deprecation message is available in the dark console (and in log). Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15554 Differential Revision: https://we.phorge.it/D25386
1 parent aeab4ef commit 94c0774

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public static function handleErrors($event, $value, $metadata) {
4444
'trace' => $metadata['trace'],
4545
);
4646
break;
47+
case PhutilErrorHandler::DEPRECATED:
4748
case PhutilErrorHandler::ERROR:
4849
// $value is a simple string
4950
self::$errors[] = array(

0 commit comments

Comments
 (0)