Replace dedicated Commit Field with an existing one

avivey · avivey · commit eb0bb1736891 · 2023-08-11T11:42:50.000-07:00
Summary: fix T15600 Test Plan: arc diff against this Reviewers: Sten, O1 Blessed Committers! Reviewed By: Sten Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15600 Differential Revision: https://we.phorge.it/D25385
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
@@ -714,7 +714,6 @@
     'DifferentialTabReplacementTestCase' => 'applications/differential/parser/__tests__/DifferentialTabReplacementTestCase.php',
     'DifferentialTagsCommitMessageField' => 'applications/differential/field/DifferentialTagsCommitMessageField.php',
     'DifferentialTasksCommitMessageField' => 'applications/differential/field/DifferentialTasksCommitMessageField.php',
-    'DifferentialTestCommitMessageField' => 'applications/differential/field/DifferentialTestCommitMessageField.php',
     'DifferentialTestPlanCommitMessageField' => 'applications/differential/field/DifferentialTestPlanCommitMessageField.php',
     'DifferentialTestPlanField' => 'applications/differential/customfield/DifferentialTestPlanField.php',
     'DifferentialTitleCommitMessageField' => 'applications/differential/field/DifferentialTitleCommitMessageField.php',
@@ -6761,7 +6760,6 @@
     'DifferentialTabReplacementTestCase' => 'PhabricatorTestCase',
     'DifferentialTagsCommitMessageField' => 'DifferentialCommitMessageField',
     'DifferentialTasksCommitMessageField' => 'DifferentialCommitMessageField',
-    'DifferentialTestCommitMessageField' => 'DifferentialCommitMessageField',
     'DifferentialTestPlanCommitMessageField' => 'DifferentialCommitMessageField',
     'DifferentialTestPlanField' => 'DifferentialCoreCustomField',
     'DifferentialTitleCommitMessageField' => 'DifferentialCommitMessageField',
diff --git a/src/applications/differential/field/DifferentialTestCommitMessageField.php b/src/applications/differential/field/DifferentialTestCommitMessageField.php
diff --git a/src/applications/differential/field/__tests__/DifferentialCommitMessageFieldTestCase.php b/src/applications/differential/field/__tests__/DifferentialCommitMessageFieldTestCase.php
@@ -29,7 +29,7 @@ public function testRevisionCommitMessageFieldParsing() {
   }
 
   public function testRenderFieldValue() {
-    $test_object = new DifferentialTestCommitMessageField();
+    $test_object = new DifferentialRevertPlanCommitMessageField();
     $this->assertEqual('foo', $test_object->renderFieldValue('foo'),
       'Normal strings should be rendered unaltered');
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function testRevisionCommitMessageFieldParsing() {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`public function testRenderFieldValue() {`
`32`		`- $test_object = new DifferentialTestCommitMessageField();`
	`32`	`+ $test_object = new DifferentialRevertPlanCommitMessageField();`
`33`	`33`	`$this->assertEqual('foo', $test_object->renderFieldValue('foo'),`
`34`	`34`	`'Normal strings should be rendered unaltered');`
`35`	`35`