Skip to content

Commit f7d9d95

Browse files
committed
Fix Diviner strlen(null) error when clicking on a link
Summary: Fix issue whereby clicking on a link in Diviner (eg https://my.phorge.site/diviner/find/?name=Differential_User_Guide&type=article&jump=1) results in a strlen(null) error under PHP 8.1 Fixes T15635 Test Plan: * Go into the Diviner differential page /book/phorge/article/differential/ * Click on the link to Differential User Guide: Inline Comments Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15635 Differential Revision: https://we.phorge.it/D25433
1 parent 1720209 commit f7d9d95

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/applications/diviner/controller/DivinerFindController.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function handleRequest(AphrontRequest $request) {
3232
}
3333

3434
$context = $request->getStr('context');
35-
if (strlen($context)) {
35+
if (phutil_nonempty_string($context)) {
3636
$query->withContexts(array($context));
3737
}
3838

0 commit comments

Comments
 (0)