update tests to check timeseries output values

Author: thwllms

src/rashdf/plan.py

@@ -119,6 +119,7 @@ class TimeSeriesOutputVar(Enum):
     TimeSeriesOutputVar.FACE_TANGENTIAL_VELOCITY,
     TimeSeriesOutputVar.FACE_VELOCITY,
     TimeSeriesOutputVar.FACE_WATER_SURFACE,
+    # TODO: investigate why "Face Wind Term" data gets written as a 1D array
     # TimeSeriesOutputVar.FACE_WIND_TERM,
 ]
 
@@ -830,6 +831,7 @@ def mesh_timeseries_output(
             raise ValueError(f"Invalid time series output variable: {var.value}")
         da = xr.DataArray(
             values,
+            name=var.value,
             dims=["time", id_coord],
             coords={
                 "time": times,
@@ -853,7 +855,7 @@ def _mesh_timeseries_outputs(
                 continue
             da = self.mesh_timeseries_output(mesh_name, var)
             datasets[var.value] = da
-        ds = xr.Dataset(datasets)
+        ds = xr.Dataset(datasets, attrs={"mesh_name": mesh_name})
         return ds
 
     def mesh_timeseries_output_cells(self, mesh_name: str) -> xr.Dataset:

tests/data/csv/BaldEagleDamBrk.BaldEagleCr.v.678.csv

@@ -0,0 +1,38 @@
+time,face_id,Face Velocity
+1999-01-01 12:00:00,678,0.0
+1999-01-01 14:00:00,678,0.0
+1999-01-01 16:00:00,678,0.0
+1999-01-01 18:00:00,678,0.0
+1999-01-01 20:00:00,678,0.0
+1999-01-01 22:00:00,678,0.0
+1999-01-02 00:00:00,678,0.0
+1999-01-02 02:00:00,678,0.0
+1999-01-02 04:00:00,678,0.0
+1999-01-02 06:00:00,678,0.0
+1999-01-02 08:00:00,678,0.0
+1999-01-02 10:00:00,678,0.0
+1999-01-02 12:00:00,678,0.0
+1999-01-02 14:00:00,678,0.0
+1999-01-02 16:00:00,678,0.0
+1999-01-02 18:00:00,678,0.0
+1999-01-02 20:00:00,678,0.0
+1999-01-02 22:00:00,678,0.0
+1999-01-03 00:00:00,678,0.0
+1999-01-03 02:00:00,678,0.0
+1999-01-03 04:00:00,678,0.0
+1999-01-03 06:00:00,678,-0.28543922
+1999-01-03 08:00:00,678,-0.94968337
+1999-01-03 10:00:00,678,-1.1934088
+1999-01-03 12:00:00,678,-1.3193293
+1999-01-03 14:00:00,678,-1.448421
+1999-01-03 16:00:00,678,-1.5487186
+1999-01-03 18:00:00,678,-1.6022989
+1999-01-03 20:00:00,678,-1.6255693
+1999-01-03 22:00:00,678,-1.6309046
+1999-01-04 00:00:00,678,-1.625484
+1999-01-04 02:00:00,678,-1.6135458
+1999-01-04 04:00:00,678,-1.5972468
+1999-01-04 06:00:00,678,-1.5781946
+1999-01-04 08:00:00,678,-1.5570217
+1999-01-04 10:00:00,678,-1.5398287
+1999-01-04 12:00:00,678,-1.5226055

tests/data/csv/BaldEagleDamBrk.BaldEagleCr.ws.123.csv

@@ -0,0 +1,38 @@
+time,cell_id,Water Surface
+1999-01-01 12:00:00,123,537.2959
+1999-01-01 14:00:00,123,537.2959
+1999-01-01 16:00:00,123,537.2959
+1999-01-01 18:00:00,123,537.2959
+1999-01-01 20:00:00,123,537.2959
+1999-01-01 22:00:00,123,537.2959
+1999-01-02 00:00:00,123,537.2959
+1999-01-02 02:00:00,123,537.2959
+1999-01-02 04:00:00,123,537.2959
+1999-01-02 06:00:00,123,537.2959
+1999-01-02 08:00:00,123,537.2959
+1999-01-02 10:00:00,123,537.2959
+1999-01-02 12:00:00,123,537.2959
+1999-01-02 14:00:00,123,537.2959
+1999-01-02 16:00:00,123,537.2959
+1999-01-02 18:00:00,123,537.2959
+1999-01-02 20:00:00,123,537.2959
+1999-01-02 22:00:00,123,537.2959
+1999-01-03 00:00:00,123,537.2959
+1999-01-03 02:00:00,123,537.2959
+1999-01-03 04:00:00,123,537.2959
+1999-01-03 06:00:00,123,537.39996
+1999-01-03 08:00:00,123,543.78345
+1999-01-03 10:00:00,123,546.0193
+1999-01-03 12:00:00,123,547.2876
+1999-01-03 14:00:00,123,548.71246
+1999-01-03 16:00:00,123,549.9208
+1999-01-03 18:00:00,123,550.59985
+1999-01-03 20:00:00,123,550.90826
+1999-01-03 22:00:00,123,550.9861
+1999-01-04 00:00:00,123,550.92456
+1999-01-04 02:00:00,123,550.7785
+1999-01-04 04:00:00,123,550.5764
+1999-01-04 06:00:00,123,550.3424
+1999-01-04 08:00:00,123,550.0916
+1999-01-04 10:00:00,123,549.85077
+1999-01-04 12:00:00,123,549.6207

tests/data/csv/BaldEagleDamBrk.Upper2DArea.v.567.csv

@@ -0,0 +1,38 @@
+time,face_id,Face Velocity
+1999-01-01 12:00:00,567,0.0
+1999-01-01 14:00:00,567,0.0
+1999-01-01 16:00:00,567,0.0
+1999-01-01 18:00:00,567,0.0
+1999-01-01 20:00:00,567,0.0
+1999-01-01 22:00:00,567,0.0
+1999-01-02 00:00:00,567,0.0
+1999-01-02 02:00:00,567,0.0
+1999-01-02 04:00:00,567,0.0
+1999-01-02 06:00:00,567,0.0
+1999-01-02 08:00:00,567,0.0
+1999-01-02 10:00:00,567,0.0
+1999-01-02 12:00:00,567,0.0
+1999-01-02 14:00:00,567,0.0
+1999-01-02 16:00:00,567,-0.08126567
+1999-01-02 18:00:00,567,-0.031525202
+1999-01-02 20:00:00,567,-0.05927151
+1999-01-02 22:00:00,567,-0.08731246
+1999-01-03 00:00:00,567,-0.10861763
+1999-01-03 02:00:00,567,-0.13474327
+1999-01-03 04:00:00,567,-0.15085366
+1999-01-03 06:00:00,567,-0.13912068
+1999-01-03 08:00:00,567,-0.16435227
+1999-01-03 10:00:00,567,-0.16623442
+1999-01-03 12:00:00,567,-0.16526061
+1999-01-03 14:00:00,567,-0.16261855
+1999-01-03 16:00:00,567,-0.15927659
+1999-01-03 18:00:00,567,-0.15739673
+1999-01-03 20:00:00,567,-0.15771057
+1999-01-03 22:00:00,567,-0.094285294
+1999-01-04 00:00:00,567,-0.069785364
+1999-01-04 02:00:00,567,-0.055208486
+1999-01-04 04:00:00,567,-0.04507809
+1999-01-04 06:00:00,567,-0.037555225
+1999-01-04 08:00:00,567,-0.031792343
+1999-01-04 10:00:00,567,-0.0249611
+1999-01-04 12:00:00,567,-0.021199187

tests/data/csv/BaldEagleDamBrk.Upper2DArea.ws.456.csv

@@ -0,0 +1,38 @@
+time,cell_id,Water Surface
+1999-01-01 12:00:00,456,632.2363
+1999-01-01 14:00:00,456,632.2363
+1999-01-01 16:00:00,456,632.2363
+1999-01-01 18:00:00,456,632.2363
+1999-01-01 20:00:00,456,632.2363
+1999-01-01 22:00:00,456,632.6684
+1999-01-02 00:00:00,456,634.0546
+1999-01-02 02:00:00,456,635.6736
+1999-01-02 04:00:00,456,637.54553
+1999-01-02 06:00:00,456,639.678
+1999-01-02 08:00:00,456,642.2366
+1999-01-02 10:00:00,456,645.18005
+1999-01-02 12:00:00,456,648.437
+1999-01-02 14:00:00,456,651.93463
+1999-01-02 16:00:00,456,655.60315
+1999-01-02 18:00:00,456,659.2467
+1999-01-02 20:00:00,456,662.27795
+1999-01-02 22:00:00,456,664.529
+1999-01-03 00:00:00,456,666.1582
+1999-01-03 02:00:00,456,667.3115
+1999-01-03 04:00:00,456,668.081
+1999-01-03 06:00:00,456,668.5928
+1999-01-03 08:00:00,456,668.88885
+1999-01-03 10:00:00,456,669.04114
+1999-01-03 12:00:00,456,669.07465
+1999-01-03 14:00:00,456,668.9937
+1999-01-03 16:00:00,456,668.8436
+1999-01-03 18:00:00,456,668.656
+1999-01-03 20:00:00,456,668.4458
+1999-01-03 22:00:00,456,668.22107
+1999-01-04 00:00:00,456,667.9862
+1999-01-04 02:00:00,456,667.744
+1999-01-04 04:00:00,456,667.49695
+1999-01-04 06:00:00,456,667.2534
+1999-01-04 08:00:00,456,667.01154
+1999-01-04 10:00:00,456,666.7654
+1999-01-04 12:00:00,456,666.51526

tests/test_plan.py

@@ -7,12 +7,16 @@
 
 from pathlib import Path
 
+import numpy as np
+import pandas as pd
+from pandas.testing import assert_frame_equal
 import pytest
 
 from . import _create_hdf_with_group_attrs, _gdf_matches_json, get_sha1_hash
 
 TEST_DATA = Path("./tests/data")
 TEST_JSON = TEST_DATA / "json"
+TEST_CSV = TEST_DATA / "csv"
 TEST_ATTRS = {"test_attribute1": "test_str1", "test_attribute2": 500}
 BALD_EAGLE_P18 = TEST_DATA / "ras/BaldEagleDamBrk.p18.hdf"
 BALD_EAGLE_P18_TIMESERIES = TEST_DATA / "ras/BaldEagleDamBrk.p18.timeseries.hdf"
@@ -186,19 +190,35 @@ def test_mesh_timeseries_output_cells():
         assert "time" in ds.coords
         assert "cell_id" in ds.coords
         assert "Water Surface" in ds.variables
-        water_surface = ds["Water Surface"]
-        assert water_surface.shape == (37, 3359)
-        assert water_surface.attrs["units"] == "ft"
-        assert water_surface.attrs["mesh_name"] == "BaldEagleCr"
+        ws = ds["Water Surface"]
+        assert ws.shape == (37, 3359)
+        assert ws.attrs["units"] == "ft"
+        assert ws.attrs["mesh_name"] == "BaldEagleCr"
+        df = ws.sel(cell_id=123).to_dataframe()
+        valid_df = pd.read_csv(
+            TEST_CSV / "BaldEagleDamBrk.BaldEagleCr.ws.123.csv",
+            index_col="time",
+            parse_dates=True,
+            dtype={"Water Surface": np.float32},
+        )
+        assert_frame_equal(df, valid_df)
 
         ds = plan_hdf.mesh_timeseries_output_cells("Upper 2D Area")
         assert "time" in ds.coords
         assert "cell_id" in ds.coords
         assert "Water Surface" in ds.variables
-        water_surface = ds["Water Surface"]
-        assert water_surface.shape == (37, 1066)
-        assert water_surface.attrs["units"] == "ft"
-        assert water_surface.attrs["mesh_name"] == "Upper 2D Area"
+        ws = ds["Water Surface"]
+        assert ws.shape == (37, 1066)
+        assert ws.attrs["units"] == "ft"
+        assert ws.attrs["mesh_name"] == "Upper 2D Area"
+        df = ws.sel(cell_id=456).to_dataframe()
+        valid_df = pd.read_csv(
+            TEST_CSV / "BaldEagleDamBrk.Upper2DArea.ws.456.csv",
+            index_col="time",
+            parse_dates=True,
+            dtype={"Water Surface": np.float32},
+        )
+        assert_frame_equal(df, valid_df)
 
 
 def test_mesh_timeseries_output_faces():
@@ -207,10 +227,18 @@ def test_mesh_timeseries_output_faces():
         assert "time" in ds.coords
         assert "face_id" in ds.coords
         assert "Face Velocity" in ds.variables
-        ws = ds["Face Velocity"]
-        assert ws.shape == (37, 7295)
-        assert ws.attrs["units"] == "ft/s"
-        assert ws.attrs["mesh_name"] == "BaldEagleCr"
+        v = ds["Face Velocity"]
+        assert v.shape == (37, 7295)
+        assert v.attrs["units"] == "ft/s"
+        assert v.attrs["mesh_name"] == "BaldEagleCr"
+        df = v.sel(face_id=678).to_dataframe()
+        valid_df = pd.read_csv(
+            TEST_CSV / "BaldEagleDamBrk.BaldEagleCr.v.678.csv",
+            index_col="time",
+            parse_dates=True,
+            dtype={"Face Velocity": np.float32},
+        )
+        assert_frame_equal(df, valid_df)
 
         ds = plan_hdf.mesh_timeseries_output_faces("Upper 2D Area")
         assert "time" in ds.coords
@@ -220,3 +248,11 @@ def test_mesh_timeseries_output_faces():
         assert v.shape == (37, 2286)
         assert v.attrs["units"] == "ft/s"
         assert v.attrs["mesh_name"] == "Upper 2D Area"
+        df = v.sel(face_id=567).to_dataframe()
+        valid_df = pd.read_csv(
+            TEST_CSV / "BaldEagleDamBrk.Upper2DArea.v.567.csv",
+            index_col="time",
+            parse_dates=True,
+            dtype={"Face Velocity": np.float32},
+        )
+        assert_frame_equal(df, valid_df)