Skip to content

Commit 9a09021

Browse files
authored
core: Add missed internal comment about idle mode workaround
This should have been included in grpc#8746 but wasn't.
1 parent c48b01a commit 9a09021

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Diff for: core/src/main/java/io/grpc/internal/ManagedChannelImpl.java

+3
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,9 @@ private class IdleModeTimer implements Runnable {
349349

350350
@Override
351351
public void run() {
352+
// Workaround timer scheduled while in idle mode. This can happen from handleNotInUse() after
353+
// an explicit enterIdleMode() by the user. Protecting here as other locations are a bit too
354+
// subtle to change rapidly to resolve the channel panic. See #8714
352355
if (lbHelper == null) {
353356
return;
354357
}

0 commit comments

Comments
 (0)