Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update balance tracking logic (fees in v0.45.9) #109

Open
bryanchriswhite opened this issue Sep 27, 2022 · 0 comments
Open

Update balance tracking logic (fees in v0.45.9) #109

bryanchriswhite opened this issue Sep 27, 2022 · 0 comments
Assignees
Milestone

Comments

@bryanchriswhite
Copy link

bryanchriswhite commented Sep 27, 2022

Background

As noted in #89, transaction fee amounts should be available in the respective event as of cosmos-sdk v0.45.8 (currently v0.45.9 due to dragonberry). #123 implemented an alternative approach to accounting for fee amounts in the context of balance change events which is sub-optimal by comparison (i.e. requires an additional round-trip to the DB).

Acceptance Criteria

The balance change handlers don't query the DB in order to construct new entities.

@bryanchriswhite bryanchriswhite changed the title Update balance tracking logic (fees in v0.45.8) Update balance tracking logic (fees in v0.45.9) Dec 5, 2022
@bryanchriswhite bryanchriswhite added C-investigation Category: Tracking an investigation or PoC and removed C-investigation Category: Tracking an investigation or PoC labels Dec 5, 2022
@ejfitzgerald ejfitzgerald added this to the v1.0 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants