PHP8.4 support
#15388
Replies: 1 comment 4 replies
-
This is back on my radar. V4 seems like the right time to include PHP8.4 in the Filament test suite. I've tried it out on a fork of the 4.x branch and it passes with no changes needed to the codebase other than adding 8.4 to the php matrix. So my original problems with dependencies have gone away. @danharrin can we get this in? I'm very happy to do a PR. Having confidence that the app works with 8.4 seems like an important addition. |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I would like to upgrade our App to php8.4.
I note that 8.4 is not included in the Github testsuite matrix in either the 3.x or 4.x branches.
I can make the 3.x tests pass locally with 8.4, but only if I bump rector, phpstan and larastan to the next major versions.
I'd expect the change need to make this happen is as simple as adjusting composer to support both versions e.g.
larastan/larastan": "^2.2|^3.0"
and then forcing the higher version in the host app.I'd be very happy to do this work and test it if it's likely to be accepted.
Beta Was this translation helpful? Give feedback.
All reactions