Add a flag "headerPadding" to FIlament Page

[danielhe4rt]

Motivation

Recently I've decided to use more often the "Guest Panel" to build landing pages and every time that I start a new project, I need to copy the vendor filament-panels::page.index and add a new flag to remove the padding only.

See the white gap between the edges:

Proposal

By adding a new component property headerPadding, we can easily solve it when creating custom pages that require the navbar.

@props([
    'fullHeight' => false,
    'headerPadding' => true, // added item
])

@php
    use Filament\Pages\Enums\SubNavigationPosition;

    $subNavigation = $this->getCachedSubNavigation();
    $subNavigationPosition = $this->getSubNavigationPosition();
    $widgetData = $this->getWidgetData();
@endphp
// ... rest of the component

<div
        {{
            $attributes->class([
                'fi-page-header-main-ctn',
                'p-0' => ! $headerPadding,
            ])
        }}
    >

Question

During my research, I tried many times to understand how the fullHeight works since at my first sight I thought that this flag would do what I'm proposing right now.

I would appreaciate if someone could elaborate it!

[ghsgabriel]

Currently, the page already has the class fi-page-has-sub-navigation when there is subnavigation.

I proposal is to also add fi-page-has-header and fi-page-has-heading.

We could remove the current padding from fi-page-header-main-ctn and instead apply it to fi-page-has-sub-navigation, fi-page-has-header, and fi-page-has-heading. This way, if any of these three classes are present, the padding will be applied. If none are present, there is no need for padding, since there will be no content between the topbar and fi-page-main.

This ensures there is only one spacing, avoiding duplication, and works automatically without requiring manual adjustments from the developer.