clang-tidy warnings fixes (#553)

Signed-off-by: Alexey Chernyshov <[email protected]>

Author: Alexey-N-Chernyshov

core/cbor_blake/ipld_any.hpp

@@ -48,7 +48,7 @@ namespace fc {
 
     static bool get(const IpldPtr &ipld, const CbCid &key, Bytes *value) {
       const CID cid{key};
-      if (value) {
+      if (value != nullptr) {
         if (auto r{ipld->get(cid)}) {
           *value = std::move(r.value());
           return true;

core/codec/cbor/light_reader/hamt_walk.hpp

@@ -18,10 +18,11 @@ namespace fc::codec::cbor::light_reader {
      * @param[out] value
      * @return
      */
+    // NOLINTNEXTLINE(readability-function-cognitive-complexity)
     inline bool next(BytesIn &key, BytesIn &value) {
       cbor::CborToken token;
       while (!empty()) {
-        if (_bucket) {
+        if (_bucket != 0) {
           --_bucket;
           if (read(token, node).listCount() != 2) {
             return false;
@@ -69,7 +70,7 @@ namespace fc::codec::cbor::light_reader {
             }
           }
           if (token.cidSize()) {
-            const CbCid *cid;
+            const CbCid *cid = nullptr;
             if (!readCborBlake(cid, token, node)) {
               return false;
             }

core/codec/cbor/light_reader/miner_actor_reader.hpp

@@ -36,7 +36,7 @@ namespace fc::codec::cbor::light_reader {
       return kParseError;
     }
     // read miner info CID
-    const CbCid *miner_info;
+    const CbCid *miner_info = nullptr;
     if (!cbor::readCborBlake(miner_info, input)) {
       return kParseError;
     }
@@ -76,7 +76,7 @@ namespace fc::codec::cbor::light_reader {
       return kParseError;
     }
     // sectors
-    const CbCid *sectors;
+    const CbCid *sectors = nullptr;
     if (!cbor::readCborBlake(sectors, input)) {
       return kParseError;
     }
@@ -89,7 +89,7 @@ namespace fc::codec::cbor::light_reader {
       return kParseError;
     }
     // deadlines
-    const CbCid *deadlines;
+    const CbCid *deadlines = nullptr;
     if (!cbor::readCborBlake(deadlines, input)) {
       return kParseError;
     }

core/codec/cbor/light_reader/state_tree.hpp

@@ -28,7 +28,7 @@ namespace fc::codec::cbor::light_reader {
       if (!read(token, input).asUint()) {
         return false;
       }
-      const CbCid *cid;
+      const CbCid *cid = nullptr;
       if (!cbor::readCborBlake(cid, input)) {
         return false;
       }

core/codec/cbor/light_reader/storage_power_actor_reader.hpp

@@ -44,7 +44,7 @@ namespace fc::codec::cbor::light_reader {
       }
     }
     // claims
-    const CbCid *claims;
+    const CbCid *claims = nullptr;
     if (!cbor::readCborBlake(claims, input)) {
       return kParseError;
     }

core/common/bytes_stream.hpp

@@ -15,7 +15,7 @@ namespace fc {
     boost::iostreams::array_source device;
     boost::iostreams::stream<decltype(device)> s;
 
-    BytesIstream(BytesIn bytes)
+    explicit BytesIstream(BytesIn bytes)
         : device{common::span::bytestr(bytes.data()),
                  static_cast<size_t>(bytes.size())},
           s{device} {}

core/common/libp2p/stream_read_buffer.hpp

@@ -31,22 +31,23 @@ namespace libp2p::connection {
       readSome(out,
                out.size(),
                [weak{weak_from_this()}, out, n, cb{std::move(cb)}](
-                   outcome::result<size_t> _r) {
+                   outcome::result<size_t> _r) mutable {
                  OUTCOME_CB(auto r, _r);
                  if (auto self{weak.lock()}) {
                    const auto _r{static_cast<ptrdiff_t>(r)};
                    assert(_r <= out.size());
                    if (_r == out.size()) {
                      return cb(n);
                    }
-                   self->readFull(out.subspan(r), n, std::move(cb));
+                   self->readFull(
+                       out.subspan(gsl::narrow<int64_t>(r)), n, std::move(cb));
                  }
                });
     }
 
     void read(BytesOut out, size_t n, ReadCallbackFunc cb) override {
       assert(out.size() >= static_cast<ptrdiff_t>(n));
-      readFull(out.first(n), n, std::move(cb));
+      readFull(out.first(gsl::narrow<int64_t>(n)), n, std::move(cb));
     }
 
     void readSome(BytesOut out, size_t n, ReadCallbackFunc cb) override {
@@ -56,15 +57,16 @@ namespace libp2p::connection {
       }
       if (size() != 0) {
         n = std::min(n, size());
-        std::copy_n(buffer->begin() + begin, n, out.begin());
+        std::copy_n(
+            buffer->begin() + gsl::narrow<int64_t>(begin), n, out.begin());
         begin += n;
         return cb(n);
       }
       stream->readSome(
           *buffer,
           buffer->size(),
           [weak{weak_from_this()}, out, n, cb{std::move(cb)}, buffer{buffer}](
-              outcome::result<size_t> _r) {
+              outcome::result<size_t> _r) mutable {
             OUTCOME_CB(auto r, _r);
             if (auto self{weak.lock()}) {
               self->begin = 0;

core/common/outcome_fmt.hpp

@@ -22,7 +22,7 @@ struct fmt::formatter<std::error_code, char, void> {
     const auto *it{ctx.begin()};
     if (it != ctx.end() && *it == '#') {
       alt = true;
-      ++it;
+      std::advance(it, 1);
     }
     return it;
   }

core/const.hpp

@@ -14,6 +14,7 @@ namespace fc {
   using primitives::StoragePower;
   using primitives::TokenAmount;
 
+  // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
   extern bool kFakeWinningPost;
   constexpr std::string_view kFakeWinningPostStr{"valid proof"};
 

core/storage/car/cids_index/cids_index.hpp

@@ -42,10 +42,10 @@ namespace fc::storage::cids_index {
     /** fixed-size key */
     CbCid key;
     /** 40bit offset, up to 1TB */
-    boost::endian::big_uint40_buf_t offset;
+    boost::endian::big_uint40_buf_t offset{};
     /** 24bit(+6bit) size, up to 1GB */
     /** size64=0 means this row is meta */
-    boost::endian::big_uint24_buf_t max_size64;
+    boost::endian::big_uint24_buf_t max_size64{};
 
     inline bool isMeta() const {
       return max_size64.value() == 0;
@@ -89,7 +89,9 @@ namespace fc::storage::cids_index {
   struct MergeRange {
     std::istream *file{};
     std::vector<Row> rows;
-    size_t current{(size_t)-1}, begin{}, end{};
+    size_t current = -1;
+    size_t begin{};
+    size_t end{};
 
     inline auto &front() const {
       assert(current < rows.size());