Skip to content

Commit 391867a

Browse files
committed
simplify the code
1 parent ec37ebd commit 391867a

File tree

1 file changed

+3
-9
lines changed
  • firebase-firestore/src/main/java/com/google/firebase/firestore/util

1 file changed

+3
-9
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/util/Util.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,8 @@
2727
import io.grpc.Status;
2828
import io.grpc.StatusException;
2929
import io.grpc.StatusRuntimeException;
30-
3130
import java.nio.charset.StandardCharsets;
3231
import java.security.SecureRandom;
33-
import java.sql.SQLOutput;
3432
import java.util.ArrayList;
3533
import java.util.Collection;
3634
import java.util.Collections;
@@ -90,8 +88,7 @@ public static int compareIntegers(int i1, int i2) {
9088

9189
/** Compare strings in UTF-8 encoded byte order */
9290
public static int compareUtf8Strings(String left, String right) {
93-
int i = 0;
94-
while (i < left.length() && i < right.length()) {
91+
for (int i = 0; i < left.length() && i < right.length(); i++) {
9592
int leftCodePoint = left.codePointAt(i);
9693
int rightCodePoint = right.codePointAt(i);
9794

@@ -103,15 +100,12 @@ public static int compareUtf8Strings(String left, String right) {
103100
// substring and do UTF-8 encoded byte comparison
104101
byte[] leftBytes = getUtf8SafeBytes(left, i);
105102
byte[] rightBytes = getUtf8SafeBytes(right, i);
106-
int comp = compareByteArrays(leftBytes,rightBytes);
107-
if(comp !=0) {
103+
int comp = compareByteArrays(leftBytes, rightBytes);
104+
if (comp != 0) {
108105
return comp;
109106
}
110107
}
111108
}
112-
113-
// Increment by 2 for surrogate pairs, 1 otherwise
114-
i += Character.charCount(leftCodePoint);
115109
}
116110

117111
// Compare lengths if all characters are equal

0 commit comments

Comments
 (0)