UtilTest.java: make sure that most generated strings have a common pr…

…efix
firebase · Feb 19, 2025 · 4c4d1a7 · 4c4d1a7
1 parent b740bcc
commit 4c4d1a7
Showing 1 changed file with 36 additions and 5 deletions.
diff --git a/firebase-firestore/src/test/java/com/google/firebase/firestore/util/UtilTest.java b/firebase-firestore/src/test/java/com/google/firebase/firestore/util/UtilTest.java
@@ -93,12 +93,17 @@ private void validateDiffCollection(List<String> before, List<String> after) {
   @Test
   public void compareUtf8StringsShouldReturnCorrectValue() {
     ArrayList<String> errors = new ArrayList<>();
-    int seed = new Random().nextInt();
+    int seed = new Random().nextInt(Integer.MAX_VALUE);
     int passCount = 0;
-    StringGenerator stringGenerator = new StringGenerator(seed);
+    StringGenerator stringGenerator = new StringGenerator(29750468);
+    StringPairGenerator stringPairGenerator = new StringPairGenerator(stringGenerator);
     for (int i = 0; i < 1_000_000 && errors.size() < 10; i++) {
-      String s1 = stringGenerator.next();
-      String s2 = stringGenerator.next();
+      final String s1, s2;
+      {
+        StringPairGenerator.StringPair stringPair = stringPairGenerator.next();
+        s1 = stringPair.s1;
+        s2 = stringPair.s2;
+      }
 
       int actual = Util.compareUtf8Strings(s1, s2);
 
@@ -140,6 +145,31 @@ public void compareUtf8StringsShouldReturnCorrectValue() {
     }
   }
 
+  private static class StringPairGenerator {
+
+    private final StringGenerator stringGenerator;
+
+    public StringPairGenerator(StringGenerator stringGenerator) {
+      this.stringGenerator = stringGenerator;
+    }
+
+    public StringPair next() {
+      String prefix = stringGenerator.next();
+      String s1 = prefix + stringGenerator.next();
+      String s2 = prefix + stringGenerator.next();
+      return new StringPair(s1, s2);
+    }
+
+    public static class StringPair {
+      public final String s1, s2;
+
+      public StringPair(String s1, String s2) {
+        this.s1 = s1;
+        this.s2 = s2;
+      }
+    }
+  }
+
   private static class StringGenerator {
 
     private static final float DEFAULT_SURROGATE_PAIR_PROBABILITY = 0.33f;
@@ -214,7 +244,8 @@ public String next() {
       final int length = rnd.nextInt(maxLength + 1);
       final StringBuilder sb = new StringBuilder();
       while (sb.length() < length) {
-        sb.appendCodePoint(nextCodePoint());
+        int codePoint = nextCodePoint();
+        sb.appendCodePoint(codePoint);
       }
       return sb.toString();
     }