Skip to content

Commit 6912996

Browse files
Fix: Resolve UnboundLocalError and remove absl-py dependency
- Fixes an `UnboundLocalError` for `latest_overall_review_activity_dt` by ensuring it and related timestamp-tracking variables are initialized at the beginning of the `main()` function scope before potential use. - Removes the `absl-py` dependency from the script: - Deletes the `absl` import and `logging.set_verbosity()` call. - All `logging.info()` calls (previously used for API call details) have been removed to reduce verbosity. - `logging.error()` calls have been replaced with direct writes to `sys.stderr`, prefixed with "Error:". This simplifies dependencies and resolves the runtime error, while ensuring important error messages are still reported.
1 parent 438ed8a commit 6912996

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

scripts/print_github_reviews.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import subprocess
2727
from requests.adapters import HTTPAdapter
2828
from requests.packages.urllib3.util.retry import Retry
29-
from absl import logging
29+
# from absl import logging # Removed
3030

3131
# Constants for GitHub API interaction
3232
RETRIES = 3
@@ -43,7 +43,7 @@
4343
BASE_URL = 'https://api.github.com' # Base URL for GitHub API
4444
GITHUB_API_URL = '' # Dynamically constructed API URL for the specific repository
4545

46-
logging.set_verbosity(logging.WARNING)
46+
# logging.set_verbosity(logging.WARNING) # Removed
4747

4848

4949
def set_repo_url_standalone(owner_name, repo_name):
@@ -90,7 +90,7 @@ def get_pull_request_review_comments(token, pull_number, since=None):
9090
with requests_retry_session().get(url, headers=headers, params=current_page_params,
9191
stream=True, timeout=TIMEOUT) as response:
9292
response.raise_for_status()
93-
logging.info("get_pull_request_review_comments: %s params %s response: %s", url, current_page_params, response)
93+
# logging.info("get_pull_request_review_comments: %s params %s response: %s", url, current_page_params, response) # Removed
9494

9595
current_page_results = response.json()
9696
if not current_page_results: # No more data on this page
@@ -104,7 +104,7 @@ def get_pull_request_review_comments(token, pull_number, since=None):
104104
page += 1
105105

106106
except requests.exceptions.RequestException as e:
107-
logging.error(f"Error fetching review comments (page {page}, params: {current_page_params}) for PR {pull_number}: {e}")
107+
sys.stderr.write(f"Error: Failed to fetch review comments (page {page}, params: {current_page_params}) for PR {pull_number}: {e}\n")
108108
return None # Indicate error
109109
return results
110110

@@ -127,15 +127,15 @@ def list_pull_requests(token, state, head, base):
127127
try:
128128
with requests_retry_session().get(url, headers=headers, params=params,
129129
stream=True, timeout=TIMEOUT) as response:
130-
logging.info("list_pull_requests: %s params: %s response: %s", url, params, response)
130+
# logging.info("list_pull_requests: %s params: %s response: %s", url, params, response) # Removed
131131
response.raise_for_status()
132132
current_page_results = response.json()
133133
if not current_page_results:
134134
break
135135
results.extend(current_page_results)
136136
keep_going = (len(current_page_results) == per_page)
137137
except requests.exceptions.RequestException as e:
138-
logging.error(f"Error listing pull requests (page {params.get('page', 'N/A')}, params: {params}) for {OWNER}/{REPO}: {e}")
138+
sys.stderr.write(f"Error: Failed to list pull requests (page {params.get('page', 'N/A')}, params: {params}) for {OWNER}/{REPO}: {e}\n")
139139
return None # Indicate error
140140
return results
141141

@@ -157,15 +157,15 @@ def get_pull_request_reviews(token, owner, repo, pull_number):
157157
try:
158158
with requests_retry_session().get(url, headers=headers, params=params,
159159
stream=True, timeout=TIMEOUT) as response:
160-
logging.info("get_pull_request_reviews: %s params: %s response: %s", url, params, response)
160+
# logging.info("get_pull_request_reviews: %s params: %s response: %s", url, params, response) # Removed
161161
response.raise_for_status()
162162
current_page_results = response.json()
163163
if not current_page_results:
164164
break
165165
results.extend(current_page_results)
166166
keep_going = (len(current_page_results) == per_page)
167167
except requests.exceptions.RequestException as e:
168-
logging.error(f"Error listing pull request reviews (page {params.get('page', 'N/A')}, params: {params}) for PR {pull_number} in {owner}/{repo}: {e}")
168+
sys.stderr.write(f"Error: Failed to list pull request reviews (page {params.get('page', 'N/A')}, params: {params}) for PR {pull_number} in {owner}/{repo}: {e}\n")
169169
return None # Indicate error
170170
return results
171171

0 commit comments

Comments
 (0)