You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Address review comment: Simplify UseUserAccessGroup integration test
This commit incorporates feedback from the code review regarding the
integration test for `UseUserAccessGroup`:
- Simplified the `TestUseUserAccessGroupDoesNotCrash` test in
`auth/integration_test/src/integration_test.cc`.
- Removed platform-specific checks (`#if TARGET_OS_IPHONE`) and
associated `EXPECT_THAT` calls.
- Removed `LogDebug` messages from the test.
- Both calls to `UseUserAccessGroup` now uniformly expect
`firebase::auth::kAuthErrorNone`. This aligns with the stub behavior
on non-iOS platforms and simplifies the test as requested by the
reviewer, focusing on ensuring the calls do not crash and stubs
return the expected no-op error code.
0 commit comments