refactor: remove unnecessary delete key

Author: Salakar

src/firebase_functions/options.py

@@ -253,8 +253,6 @@ def _asdict_with_global_options(self) -> dict:
             for option in resettable_options:
                 if option not in merged_options:
                     merged_options[option] = RESET_VALUE
-        if "preserve_external_changes" in merged_options:
-            del merged_options["preserve_external_changes"]
         # _util.Sentinel values are converted to `None` in ManifestEndpoint generation
         # after other None values are removed - so as to keep them in the generated
         # YAML output as 'null' values.

tests/test_options.py

@@ -87,9 +87,6 @@ def test_options_preserve_external_changes():
         min_instances=5,
     )
     options_asdict = options._GLOBAL_OPTIONS._asdict_with_global_options()
-    assert ("preserve_external_changes"
-            not in options_asdict), "option is still set"
-
     assert (options_asdict["max_instances"] is
             options.RESET_VALUE), "option should be RESET_VALUE"
     assert options_asdict["min_instances"] == 5, "option should be set"