add: additional tests

Author: exaby73

src/firebase_functions/logger.py

@@ -40,12 +40,11 @@ def _entry_from_args(severity: LogSeverity, **kwargs) -> LogEntry:
     Creates a `LogEntry` from the given arguments.
     """
 
-    message: str = " ".join(
-        # do we need to replace_circular here?
-        [
-            value if isinstance(value, str) else _json.dumps(
-                _remove_circular(value)) for value in kwargs.values()
-        ])
+    message: str = " ".join([
+        value
+        if isinstance(value, str) else _json.dumps(_remove_circular(value))
+        for value in kwargs.values()
+    ])
 
     return {"severity": severity, "message": message}
 

tests/test_logger.py

@@ -27,8 +27,48 @@ def test_log_should_have_severity(self, capsys: pytest.CaptureFixture[str]):
         log_output = json.loads(raw_log_output)
         assert "severity" in log_output
 
+    def test_severity_should_be_debug(self, capsys: pytest.CaptureFixture[str]):
+        logger.debug(foo="bar")
+        raw_log_output = capsys.readouterr().out
+        log_output = json.loads(raw_log_output)
+        assert log_output["severity"] == "DEBUG"
+
+    def test_severity_should_be_notice(self,
+                                       capsys: pytest.CaptureFixture[str]):
+        logger.log(foo="bar")
+        raw_log_output = capsys.readouterr().out
+        log_output = json.loads(raw_log_output)
+        assert log_output["severity"] == "NOTICE"
+
+    def test_severity_should_be_info(self, capsys: pytest.CaptureFixture[str]):
+        logger.info(foo="bar")
+        raw_log_output = capsys.readouterr().out
+        log_output = json.loads(raw_log_output)
+        assert log_output["severity"] == "INFO"
+
+    def test_severity_should_be_warning(self,
+                                        capsys: pytest.CaptureFixture[str]):
+        logger.warn(foo="bar")
+        raw_log_output = capsys.readouterr().out
+        log_output = json.loads(raw_log_output)
+        assert log_output["severity"] == "WARNING"
+
+    def test_severity_should_be_error(self, capsys: pytest.CaptureFixture[str]):
+        logger.error(foo="bar")
+        raw_log_output = capsys.readouterr().err
+        log_output = json.loads(raw_log_output)
+        assert log_output["severity"] == "ERROR"
+
     def test_log_should_have_message(self, capsys: pytest.CaptureFixture[str]):
         logger.log(foo="bar")
         raw_log_output = capsys.readouterr().out
         log_output = json.loads(raw_log_output)
         assert "message" in log_output
+
+    def test_message_should_be_space_separated(
+            self, capsys: pytest.CaptureFixture[str]):
+        logger.log(foo="bar", baz="qux")
+        expected_message = "bar qux"
+        raw_log_output = capsys.readouterr().out
+        log_output = json.loads(raw_log_output)
+        assert log_output["message"] == expected_message