Merge branch 'fix-linting-ci' of https://github.com/invertase/firebase-functions-python2 into function-naming

Author: Salakar

.github/workflows/ci.yaml

@@ -22,11 +22,15 @@ jobs:
           python-version: ${{ matrix.python }}
       - name: Install dependencies
         run: |
-          python setup.py install
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt
+          python3.10 -m venv venv
+          source venv/bin/activate 
+          pip3 install --upgrade pip 
+          python3.10 -m pip install -r requirements.txt
+          python3.10 setup.py install
       - name: Test with pytest & coverage
-        run: python -m pytest --cov=src --cov-report term --cov-report html --cov-report xml
+        run: |
+          source venv/bin/activate
+          python3.10 -m pytest --cov=src --cov-report term --cov-report html --cov-report xml -vv
       # TODO requires activation for this repository on codecov website first.
       # - name: Upload coverage to Codecov
       #   uses: codecov/codecov-action@v3
@@ -41,9 +45,16 @@ jobs:
           python-version: "3.10"
       - name: Install dependencies
         run: |
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt
+          python3.10 -m venv venv
+          source venv/bin/activate 
+          pip3 install --upgrade pip 
+          python3.10 -m pip install -r requirements.txt
+          python3.10 setup.py install
       - name: Lint with pylint
-        run: pylint $(git ls-files '*.py')
+        run: |
+          source venv/bin/activate
+          python3.10 -m pylint $(git ls-files '*.py')
       - name: Lint with mypy
-        run: python -m mypy .
+        run: |
+          source venv/bin/activate
+          python3.10 -m mypy .

.pylintrc

@@ -424,6 +424,6 @@ valid-metaclass-classmethod-first-arg=mcs
 
 # Exceptions that will emit a warning when being caught. Defaults to
 # "Exception"
-overgeneral-exceptions=StandardError,
-                       Exception,
-                       BaseException
+overgeneral-exceptions=builtins.StandardError,
+                       builtins.Exception,
+                       builtins.BaseException

src/firebase_functions/private/serving.py

@@ -37,7 +37,7 @@ def get_functions():
         module = importlib.util.module_from_spec(spec)
         spec.loader.exec_module(module)
     else:
-        raise Exception(
+        raise FileNotFoundError(
             "Firebase Functions for Python could not find the main.py file in your project."
         )
     functions = inspect.getmembers(module, inspect.isfunction)

src/firebase_functions/pubsub.py

@@ -67,7 +67,7 @@ def json(self) -> _typing.Optional[T]:
             else:
                 return None
         except Exception as error:
-            raise Exception(
+            raise ValueError(
                 f"Unable to parse Pub/Sub message data as JSON: {error}"
             ) from error