From e44e480b5d710259292ad0e0489ef99330ffa353 Mon Sep 17 00:00:00 2001 From: Salakar Date: Wed, 3 May 2023 21:50:39 +0100 Subject: [PATCH] fix(test_lab): client info details can be undefined (fixes test_lab_fn: Error when triggered by unlabeled test #64) --- src/firebase_functions/test_lab_fn.py | 2 +- tests/test_test_lab_fn.py | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/firebase_functions/test_lab_fn.py b/src/firebase_functions/test_lab_fn.py index f147261..759d33d 100644 --- a/src/firebase_functions/test_lab_fn.py +++ b/src/firebase_functions/test_lab_fn.py @@ -222,7 +222,7 @@ def _event_handler(func: _C1, raw: _ce.CloudEvent) -> None: ), client_info=ClientInfo( client=event_data["clientInfo"]["client"], - details=event_data["clientInfo"]["details"], + details=event_data["clientInfo"].get("details", {}), ), test_matrix_id=event_data["testMatrixId"], ) diff --git a/tests/test_test_lab_fn.py b/tests/test_test_lab_fn.py index 9485618..faa15dd 100644 --- a/tests/test_test_lab_fn.py +++ b/tests/test_test_lab_fn.py @@ -78,9 +78,6 @@ def test_event_handler(self): }, "clientInfo": { "client": "gcloud", - "details": { - "someKey": "someValue", - }, }, "testMatrixId": "testmatrix-123", })