Skip to content

Commit 0fca604

Browse files
committed
Merge remote-tracking branch 'origin/main' into mtewani/implement-promises-fdc
2 parents 98295f3 + 645487b commit 0fca604

File tree

90 files changed

+3615
-2852
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

90 files changed

+3615
-2852
lines changed

.changeset/bright-scissors-care.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

.changeset/fluffy-rules-pretend.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@firebase/app-check': patch
3+
'@firebase/util': patch
4+
---
5+
6+
Generate UUIDs with `crypto.randomUUID()` instead of custom uuidv4 function that uses `Math.random()`.

.changeset/four-baboons-behave.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.changeset/funny-weeks-attack.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.changeset/hip-apricots-end.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@firebase/remote-config-types': minor
3+
'@firebase/remote-config': minor
4+
'firebase': minor
5+
---
6+
7+
Added support for custom signal targeting in Remote Config. Use `setCustomSignals` API for setting custom signals and use them to build custom targeting conditions in Remote Config.

.changeset/neat-beans-rescue.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.github/CODEOWNERS

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ packages/messaging-interop-types @zwu52 @firebase/jssdk-global-approvers
3737
integration/messaging @zwu52 @firebase/jssdk-global-approvers
3838

3939
# Auth Code
40-
packages/auth @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
41-
packages/auth-compat @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
42-
packages/auth-types @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
43-
packages/auth-interop-types @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
40+
packages/auth @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
41+
packages/auth-compat @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
42+
packages/auth-types @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
43+
packages/auth-interop-types @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
4444

4545
# Testing Code
4646
packages/rules-unit-testing @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers

.github/workflows/e2e-test.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,12 @@ jobs:
5050
TEST_ACCOUNT: ${{ secrets.TEST_ACCOUNT }}
5151
run: |
5252
echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
53+
- name: Poll npm until version to test is available for install
54+
run: |
55+
echo "Polling npm for firebase@${{ github.event.client_payload.versionOrTag }}"
56+
node ../scripts/release/poll-npm-publish.js
57+
env:
58+
VERSION: ${{ github.event.client_payload.versionOrTag }}
5359
- name: Yarn install
5460
run: |
5561
echo "Installing firebase@${{ github.event.client_payload.versionOrTag }}"

.github/workflows/test-changed-auth.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,19 +70,12 @@ jobs:
7070
run: xvfb-run yarn test:changed auth
7171
test-firefox:
7272
name: Test Auth on Firefox If Changed
73-
# Whatever version of Firefox comes with 22.04 is causing Firefox
74-
# startup to hang when launched by karma. Need to look further into
75-
# why.
7673

77-
runs-on: ubuntu-20.04
74+
runs-on: ubuntu-latest
7875

7976
steps:
8077
- name: install Firefox stable
81-
run: |
82-
sudo apt-get update
83-
sudo apt-get install firefox
84-
sudo apt-get install wget
85-
78+
run: npx @puppeteer/browsers install firefox@stable
8679
- name: Checkout Repo
8780
uses: actions/checkout@v4
8881
with:

.github/workflows/test-changed-firestore.yml

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -169,17 +169,12 @@ jobs:
169169

170170
compat-test-firefox:
171171
name: Test Firestore Compatible on Firefox
172-
# Whatever version of Firefox comes with 22.04 is causing Firefox
173-
# startup to hang when launched by karma. Need to look further into
174-
# why.
175-
runs-on: ubuntu-20.04
172+
runs-on: ubuntu-latest
176173
needs: build
177174
if: ${{ needs.build.outputs.changed == 'true'}}
178175
steps:
179176
- name: install Firefox stable
180-
run: |
181-
sudo apt-get update
182-
sudo apt-get install firefox
177+
run: npx @puppeteer/browsers install firefox@stable
183178
- name: Set up Node (20)
184179
uses: actions/setup-node@v3
185180
with:
@@ -202,17 +197,12 @@ jobs:
202197
strategy:
203198
matrix:
204199
test-name: ["test:browser", "test:travis", "test:lite:browser", "test:browser:prod:nameddb", "test:lite:browser:nameddb"]
205-
# Whatever version of Firefox comes with 22.04 is causing Firefox
206-
# startup to hang when launched by karma. Need to look further into
207-
# why.
208-
runs-on: ubuntu-20.04
200+
runs-on: ubuntu-latest
209201
needs: build
210202
if: ${{ needs.build.outputs.changed == 'true'}}
211203
steps:
212204
- name: install Firefox stable
213-
run: |
214-
sudo apt-get update
215-
sudo apt-get install firefox
205+
run: npx @puppeteer/browsers install firefox@stable
216206
- name: Download build archive
217207
uses: actions/download-artifact@v3
218208
with:

0 commit comments

Comments
 (0)