alpha4 build (needs cleanup)

Author: MarkDuckworth

packages/firestore/externs.json

@@ -12,6 +12,7 @@
     "node_modules/typescript/lib/lib.es2015.core.d.ts",
     "node_modules/typescript/lib/lib.es2017.object.d.ts",
     "node_modules/typescript/lib/lib.es2017.string.d.ts",
+    "node_modules/typescript/lib/lib.es2019.array.d.ts",
     "node_modules/re2js/build/index.esm.d.ts",
     "packages/app-types/index.d.ts",
     "packages/app-types/private.d.ts",

packages/firestore/pipelines/pipelines.d.ts

@@ -14,14 +14,15 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { PipelineSource, Pipeline } from '../dist/pipelines';
+import { PipelineSource, Pipeline, RealtimePipeline } from '../dist/pipelines';
 
 // Augument the Firestore and Query classes with the pipeline() method.
 // This is stripped from dist/lite/pipelines.d.ts during the build
 // so it needs to be re-added here.
 declare module '@firebase/firestore' {
   interface Firestore {
     pipeline(): PipelineSource<Pipeline>;
+    realtimePipeline(): PipelineSource<RealtimePipeline>;
   }
 }
 

packages/firestore/rollup.config.js

@@ -56,7 +56,7 @@ const browserPlugins = [
     transformers: [util.removeAssertAndPrefixInternalTransformer]
   }),
   json({ preferConst: true }),
-  terser(util.manglePrivatePropertiesOptions)
+  //terser(util.manglePrivatePropertiesOptions)
 ];
 
 const allBuilds = [

packages/firestore/rollup.shared.js

@@ -108,6 +108,12 @@ const publicIdentifiers = extractPublicIdentifiers(externsPaths);
 // manually add `_delegate` because we don't have typings for the compat package
 publicIdentifiers.add('_delegate');
 
+// TODO these should not have to be added manually
+publicIdentifiers.add('pipeline');
+publicIdentifiers.add('realtimePipeline');
+publicIdentifiers.add('CorePipeline');
+publicIdentifiers.add('Constant');
+
 /**
  * Transformers that remove calls to `debugAssert` and messages for 'fail` and
  * `hardAssert`.
@@ -125,10 +131,10 @@ exports.removeAssertTransformer = removeAssertTransformer;
 const removeAssertAndPrefixInternalTransformer = service => ({
   before: [
     removeAsserts(service.getProgram()),
-    renameInternals(service.getProgram(), {
-      publicIdentifiers,
-      prefix: '__PRIVATE_'
-    })
+    // renameInternals(service.getProgram(), {
+    //   publicIdentifiers,
+    //   prefix: '__PRIVATE_'
+    // })
   ],
   after: []
 });

packages/firestore/src/core/pipeline.ts

@@ -30,6 +30,7 @@ import { debugAssert } from '../util/assert';
 import { PipelineFlavor, PipelineSourceType } from './pipeline-util';
 
 export class CorePipeline {
+  isCorePipeline = true;
   constructor(
     readonly serializer: JsonProtoSerializer,
     readonly stages: Stage[]

packages/firestore/src/core/target.ts

@@ -221,11 +221,12 @@ export function targetIsPipelineTarget(
   target: TargetOrPipeline
 ): target is CorePipeline {
   // Workaround for circular dependency
-  return target.constructor.name === 'CorePipeline';
+  return !!(target as CorePipeline).isCorePipeline;
 }
 
 export function targetIsDocumentTarget(target: Target): boolean {
   return (
+    !!target.path &&
     DocumentKey.isDocumentKey(target.path) &&
     target.collectionGroup === null &&
     target.filters.length === 0

packages/firestore/src/lite-api/pipeline_impl.ts

@@ -27,9 +27,15 @@ import { LiteUserDataWriter } from './reference_impl';
 import { Stage } from './stage';
 import { newUserDataReader } from './user_data_reader';
 
+// TODO should not  be in lite
+import { RealtimePipeline} from "../api/realtime_pipeline";
+
 declare module './database' {
   interface Firestore {
     pipeline(): PipelineSource<Pipeline>;
+
+    // TODO should not be in lite
+    realtimePipeline(): PipelineSource<RealtimePipeline>;
   }
 }
 

packages/firestore/src/lite-api/user_data_reader.ts

@@ -712,7 +712,7 @@ export function parseData(
   input = getModularInstance(input);
 
   // Workaround for circular dependency
-  if ((input as Constant).constructor.name === 'Constant') {
+  if ((input as Constant).exprType === 'Constant') {
     return (input as Constant)._getValue();
   }