Skip to content

Commit 5605d52

Browse files
committed
Added non-null parent properties to ThenableReference
1 parent b92592d commit 5605d52

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

packages/database-types/index.d.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,10 @@ export interface TransactionResult {
164164

165165
export interface ThenableReference
166166
extends Reference,
167-
Pick<Promise<Reference>, 'then' | 'catch'> {}
167+
Pick<Promise<Reference>, 'then' | 'catch'> {
168+
key: string;
169+
parent: Reference;
170+
}
168171

169172
export function enableLogging(
170173
logger?: boolean | ((a: string) => any),

packages/database/src/api/Reference.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,10 @@ export interface DatabaseReference extends Query {
119119
*/
120120
export interface ThenableReference
121121
extends DatabaseReference,
122-
Pick<Promise<DatabaseReference>, 'then' | 'catch'> {}
122+
Pick<Promise<DatabaseReference>, 'then' | 'catch'> {
123+
key: string;
124+
parent: DatabaseReference;
125+
}
123126

124127
/** A callback that can invoked to remove a listener. */
125128
export type Unsubscribe = () => void;

packages/database/src/api/Reference_impl.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,10 @@ export function onDisconnect(ref: DatabaseReference): OnDisconnect {
568568

569569
export interface ThenableReferenceImpl
570570
extends ReferenceImpl,
571-
Pick<Promise<ReferenceImpl>, 'then' | 'catch'> {}
571+
Pick<Promise<ReferenceImpl>, 'then' | 'catch'> {
572+
key: string;
573+
parent: ReferenceImpl;
574+
}
572575

573576
/**
574577
* Generates a new child location using a unique key and returns its

packages/firebase/compat/index.d.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -7370,7 +7370,10 @@ declare namespace firebase.database {
73707370

73717371
interface ThenableReference
73727372
extends firebase.database.Reference,
7373-
Pick<Promise<Reference>, 'then' | 'catch'> {}
7373+
Pick<Promise<Reference>, 'then' | 'catch'> {
7374+
key: string;
7375+
parent: Reference;
7376+
}
73747377

73757378
/**
73767379
* Logs debugging information to the console.

0 commit comments

Comments
 (0)