Skip to content

Commit 5a5fadf

Browse files
committed
Added non-null parent properties to ThenableReference
1 parent 9538a77 commit 5a5fadf

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

packages/database-types/index.d.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,10 @@ export interface TransactionResult {
166166

167167
export interface ThenableReference
168168
extends Reference,
169-
Pick<Promise<Reference>, 'then' | 'catch'> {}
169+
Pick<Promise<Reference>, 'then' | 'catch'> {
170+
key: string;
171+
parent: Reference;
172+
}
170173

171174
export function enableLogging(
172175
logger?: boolean | ((a: string) => any),

packages/database/src/api/Reference.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,10 @@ export interface DatabaseReference extends Query {
119119
*/
120120
export interface ThenableReference
121121
extends DatabaseReference,
122-
Pick<Promise<DatabaseReference>, 'then' | 'catch'> {}
122+
Pick<Promise<DatabaseReference>, 'then' | 'catch'> {
123+
key: string;
124+
parent: DatabaseReference;
125+
}
123126

124127
/** A callback that can invoked to remove a listener. */
125128
export type Unsubscribe = () => void;

packages/database/src/api/Reference_impl.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,10 @@ export function onDisconnect(ref: DatabaseReference): OnDisconnect {
570570

571571
export interface ThenableReferenceImpl
572572
extends ReferenceImpl,
573-
Pick<Promise<ReferenceImpl>, 'then' | 'catch'> {}
573+
Pick<Promise<ReferenceImpl>, 'then' | 'catch'> {
574+
key: string;
575+
parent: ReferenceImpl;
576+
}
574577

575578
/**
576579
* Generates a new child location using a unique key and returns its

packages/firebase/compat/index.d.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -7371,7 +7371,10 @@ declare namespace firebase.database {
73717371

73727372
interface ThenableReference
73737373
extends firebase.database.Reference,
7374-
Pick<Promise<Reference>, 'then' | 'catch'> {}
7374+
Pick<Promise<Reference>, 'then' | 'catch'> {
7375+
key: string;
7376+
parent: Reference;
7377+
}
73757378

73767379
/**
73777380
* Logs debugging information to the console.

0 commit comments

Comments
 (0)