Merge commit '88a8055808bdbd1c75011a94d11062460027d931' into feat/pipelines

Author: MarkDuckworth

.changeset/chilly-parrots-remember.md

@@ -0,0 +1,6 @@
+---
+'@firebase/firestore': patch
+'firebase': patch
+---
+
+Fix 'window is not defined' error when calling `clearIndexedDbPersistence` from a service worker

.changeset/floppy-schools-battle.md

@@ -0,0 +1,6 @@
+---
+'@firebase/firestore': patch
+'firebase': patch
+---
+
+Fix issue where Firestore would produce `undefined` for document snapshot data if using IndexedDB persistence and "clear site data" (or equivalent) button was pressed in the web browser.

.changeset/gentle-rocks-repeat.md

@@ -57,22 +57,25 @@ jobs:
     - name: Print blocking failure status
       run: echo "${{steps.check-changeset.outputs.BLOCKING_FAILURE}}"
     - name: Find Comment
-      uses: peter-evans/find-comment@v3
+      # This commit represents v3.1.0
+      uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e
       id: fc
       with:
         issue-number: ${{github.event.number}}
         body-includes: Changeset File Check
     - name: Create comment (missing packages)
       if: ${{!steps.fc.outputs.comment-id && steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
-      uses: peter-evans/create-or-update-comment@v4
+      # This commit represents v4.0.0
+      uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
       with:
         issue-number: ${{github.event.number}}
         body: |
           ### Changeset File Check :warning:
           ${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
     - name: Update comment (missing packages)
       if: ${{steps.fc.outputs.comment-id && steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
-      uses: peter-evans/create-or-update-comment@v4
+      # This commit represents v4.0.0
+      uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
       with:
         comment-id: ${{steps.fc.outputs.comment-id}}
         edit-mode: replace
@@ -81,7 +84,8 @@ jobs:
           ${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
     - name: Update comment (no missing packages)
       if: ${{steps.fc.outputs.comment-id && !steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
-      uses: peter-evans/create-or-update-comment@v4
+      # This commit represents v4.0.0
+      uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
       with:
         comment-id: ${{steps.fc.outputs.comment-id}}
         edit-mode: replace

.changeset/large-pants-hide.md

@@ -35,14 +35,16 @@ jobs:
           echo "latest_tag=$LATEST" >> $GITHUB_ENV
         working-directory: packages/vertexai/test-utils/vertexai-sdk-test-data
       - name: Find comment from previous run if exists
-        uses: peter-evans/find-comment@v3
+        # This commit represents v3.1.0
+        uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e
         id: fc
         with:
           issue-number: ${{github.event.number}}
           body-includes: Vertex AI Mock Responses Check
       - name: Comment on PR if newer version is available
         if: ${{env.cloned_tag != env.latest_tag && !steps.fc.outputs.comment-id}}
-        uses: peter-evans/create-or-update-comment@v4
+        # This commit represents v4.0.0
+        uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
         with:
           issue-number: ${{github.event.number}}
           body: >

.changeset/silver-jeans-sell.md

@@ -42,10 +42,12 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: 22.10.0
-      - uses: 'google-github-actions/auth@v0'
+      # This commit represents v0.8.3
+      - uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72'
         with:
           credentials_json: '${{ secrets.GCP_SA_KEY }}'
-      - uses: google-github-actions/setup-gcloud@v2
+      # This commit represents v2.1.4
+      - uses: google-github-actions/setup-gcloud@77e7a554d41e2ee56fc945c52dfd3f33d12def9a
       - run: yarn install
       - run: yarn build
       - name: Run health-metrics/binary-size test
@@ -59,10 +61,12 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: 22.10.0
-      - uses: 'google-github-actions/auth@v0'
+        # This commit represents v0.8.3
+      - uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72'
         with:
           credentials_json: '${{ secrets.GCP_SA_KEY }}'
-      - uses: google-github-actions/setup-gcloud@v2
+      # This commit represents v2.1.4
+      - uses: google-github-actions/setup-gcloud@77e7a554d41e2ee56fc945c52dfd3f33d12def9a
       - run: yarn install
       - run: yarn build
       - name: Run health-metrics/modular-exports-binary-size test

.changeset/slow-students-fry.md

@@ -23,11 +23,14 @@ jobs:
     name: Release Diffing
     runs-on: ubuntu-latest
     steps:
-      - uses: 'google-github-actions/auth@v0'
+      # This commit represents v0.8.3
+      - uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72'
         with:
           credentials_json: '${{ secrets.GCP_SA_KEY }}'
-      - uses: google-github-actions/setup-gcloud@v2
-      - uses: FirebaseExtended/github-actions/health-metrics/release-diffing@master
+      # This commit represents v2.1.4
+      - uses: google-github-actions/setup-gcloud@77e7a554d41e2ee56fc945c52dfd3f33d12def9a
+      # This commit represents v1.4
+      - uses: FirebaseExtended/github-actions/health-metrics/release-diffing@41c787c37157e4c5932b951e531c041efa5bb7a4
         with:
           repo: ${{ github.repository }}
           ref: ${{ github.ref }}

.changeset/stupid-apples-shave.md

@@ -24,6 +24,9 @@ jobs:
   release:
     name: Create Release PR
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+      contents: write
     if: ${{ !startsWith(github.event.head_commit.message, 'Version Packages (#') }}
     steps:
       - name: Checkout Repo

.changeset/tricky-actors-exercise.md

@@ -178,8 +178,7 @@ jobs:
       run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
     - name: Run unit tests
       run: |
-        xvfb-run yarn lerna run test:ci --scope '@firebase/firestore*'
-        node scripts/print_test_logs.js
+        yarn lerna run test:all:ci --scope '@firebase/firestore*' --stream --concurrency 1
       env:
         FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
         EXPERIMENTAL_MODE: true

.github/workflows/check-changeset.yml

@@ -33,15 +33,17 @@ jobs:
       with:
         # This makes Actions fetch all Git history so run-changed script can diff properly.
         fetch-depth: 0
-    - uses: 'google-github-actions/auth@v0'
+    # This commit represents v0.8.3
+    - uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72'
       if: ${{ fromJSON(env.run_terraform_steps) }}
       with:
         credentials_json: '${{ secrets.JSSDK_ACTIONS_SA_KEY }}'
 
     # create composite indexes with Terraform
     - name: Setup Terraform
       if: ${{ fromJSON(env.run_terraform_steps) }}
-      uses: hashicorp/setup-terraform@v2
+      # This commit represents v3.1.2
+      uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd
     - name: Terraform Init
       if: ${{ fromJSON(env.run_terraform_steps) }}
       run: |

.github/workflows/check-vertexai-responses.yml

@@ -258,6 +258,9 @@ export interface AuthSettings {
 // @public
 export function beforeAuthStateChanged(auth: Auth, callback: (user: User | null) => void | Promise<void>, onAbort?: () => void): Unsubscribe;
 
+// @beta
+export const browserCookiePersistence: Persistence;
+
 // @public
 export const browserLocalPersistence: Persistence;
 
@@ -596,7 +599,7 @@ export interface PasswordValidationStatus {
 
 // @public
 export interface Persistence {
-    readonly type: 'SESSION' | 'LOCAL' | 'NONE';
+    readonly type: 'SESSION' | 'LOCAL' | 'NONE' | 'COOKIE';
 }
 
 // @public

.github/workflows/health-metrics-pull-request.yml

@@ -52,6 +52,35 @@ export class DataConnect {
     setInitialized(): void;
 }
 
+// @public
+export class DataConnectError extends FirebaseError {
+    }
+
+// @public (undocumented)
+export type DataConnectErrorCode = 'other' | 'already-initialized' | 'not-initialized' | 'not-supported' | 'invalid-argument' | 'partial-error' | 'unauthorized';
+
+// @public
+export class DataConnectOperationError extends DataConnectError {
+    /* Excluded from this release type: name */
+    readonly response: DataConnectOperationFailureResponse;
+}
+
+// @public (undocumented)
+export interface DataConnectOperationFailureResponse {
+    // (undocumented)
+    readonly data?: Record<string, unknown> | null;
+    // (undocumented)
+    readonly errors: DataConnectOperationFailureResponseErrorInfo[];
+}
+
+// @public (undocumented)
+export interface DataConnectOperationFailureResponseErrorInfo {
+    // (undocumented)
+    readonly message: string;
+    // (undocumented)
+    readonly path: Array<string | number>;
+}
+
 // @public
 export interface DataConnectOptions extends ConnectorConfig {
     // (undocumented)
@@ -67,7 +96,7 @@ export interface DataConnectResult<Data, Variables> extends OpResult<Data> {
 // @public
 export interface DataConnectSubscription<Data, Variables> {
     // (undocumented)
-    errCallback?: (e?: FirebaseError) => void;
+    errCallback?: (e?: DataConnectError) => void;
     // (undocumented)
     unsubscribe: () => void;
     // (undocumented)
@@ -118,7 +147,7 @@ export interface MutationResult<Data, Variables> extends DataConnectResult<Data,
 export type OnCompleteSubscription = () => void;
 
 // @public
-export type OnErrorSubscription = (err?: FirebaseError) => void;
+export type OnErrorSubscription = (err?: DataConnectError) => void;
 
 // @public
 export type OnResultSubscription<Data, Variables> = (res: QueryResult<Data, Variables>) => void;