Skip to content

Commit edb7abe

Browse files
author
kjelko
committed
Update comments after review
1 parent 551020e commit edb7abe

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/remote-config/src/api.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export function getRemoteConfig(
6060

6161
if (options.initialFetchResponse) {
6262
// We use these initial writes as the initialization promise since they will hydrate the same
63-
// fields that storageCache.loadFromStorage would set.
63+
// fields that `storageCache.loadFromStorage` would set.
6464
rc._initializePromise = Promise.all([
6565
rc._storage.setLastSuccessfulFetchResponse(options.initialFetchResponse),
6666
rc._storage.setActiveConfigEtag(options.initialFetchResponse?.eTag || ''),
@@ -70,7 +70,7 @@ export function getRemoteConfig(
7070
options.initialFetchResponse?.config || {}
7171
)
7272
]).then();
73-
// The storageCache methods above set their in-memory fields sycnhronously, so it's
73+
// The `storageCache` methods above set their in-memory fields synchronously, so it's
7474
// safe to declare our initialization complete at this point.
7575
rc._isInitializationComplete = true;
7676
}
@@ -254,7 +254,7 @@ export function getValue(remoteConfig: RemoteConfig, key: string): Value {
254254
if (!rc._isInitializationComplete) {
255255
rc._logger.debug(
256256
`A value was requested for key "${key}" before SDK initialization completed.` +
257-
' Await on ensureInitialized if the intent was to get a previously activated value.'
257+
' Await on ensureInitialized if the intent was to get a previously activated value.'
258258
);
259259
}
260260
const activeConfig = rc._storageCache.getActiveConfig();
@@ -265,7 +265,7 @@ export function getValue(remoteConfig: RemoteConfig, key: string): Value {
265265
}
266266
rc._logger.debug(
267267
`Returning static value for key "${key}".` +
268-
' Define a default or remote value if this is unintentional.'
268+
' Define a default or remote value if this is unintentional.'
269269
);
270270
return new ValueImpl('static');
271271
}

packages/remote-config/src/public_types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ export interface FirebaseRemoteConfigObject {
6060
/**
6161
* Defines a successful response (200 or 304).
6262
*
63-
* <p>Modeled after the native {@link Response} interface, but simplified for Remote Config's
63+
* <p>Modeled after the native `Response` interface, but simplified for Remote Config's
6464
* use case.
6565
*/
6666
export interface FetchResponse {
6767
/**
6868
* The HTTP status, which is useful for differentiating success responses with data from
6969
* those without.
7070
*
71-
* <p>{@link RemoteConfigClient} is modeled after the native {@link GlobalFetch} interface, so
71+
* <p>The Remote Config client is modeled after the native `Fetch` interface, so
7272
* HTTP status is first-class.
7373
*
7474
* <p>Disambiguation: the fetch response returns a legacy "state" value that is redundant with the

0 commit comments

Comments
 (0)