Skip to content

Commit 75ebdd4

Browse files
Removed deprecated calls in Analytics, Auth, and Messaging (#1280)
* Removed deprecated calls in Analytics, Auth, and Messaging * Update Parameter.cs * Update docs/readme.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update readme.md --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 8819286 commit 75ebdd4

File tree

7 files changed

+9
-58
lines changed

7 files changed

+9
-58
lines changed

analytics/src/FirebaseAnalytics.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -292,10 +292,6 @@ public static void SetUserId(string userId) {
292292
public static void SetUserProperty(string name, string property) {
293293
FirebaseAnalyticsInternal.SetUserProperty(name, property);
294294
}
295-
296-
/// @deprecated Use ParameterGroupID instead
297-
[System.Obsolete("Use ParameterGroupID instead.")]
298-
public static string ParameterGroupId { get { return ParameterGroupID; } }
299295
}
300296

301297
}

analytics/src/Parameter.cs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ namespace Firebase.Analytics {
6161
/// AchievementParameters);
6262
/// @endcode
6363
///
64-
public class Parameter : System.IDisposable {
64+
public class Parameter {
6565

6666
internal string Name { get; set; }
6767

@@ -91,15 +91,6 @@ public Parameter(string parameterName, IEnumerable<IDictionary<string, object>>
9191
Name = parameterName;
9292
Value = parameterValue;
9393
}
94-
95-
/// @deprecated No longer needed, will be removed in the future.
96-
[System.Obsolete("No longer needed, will be removed in the future.")]
97-
public void Dispose() {}
98-
99-
/// @deprecated No longer needed, will be removed in the future.
100-
[System.Obsolete("No longer needed, will be removed in the future.")]
101-
public void Dispose(bool disposing) {}
102-
10394
}
10495

10596
}

auth/src/FirebaseUser.cs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -146,18 +146,6 @@ public Task<string> TokenAsync(bool forceRefresh) {
146146
return GetValidFirebaseUserInternal().TokenAsync(forceRefresh);
147147
}
148148

149-
/// @deprecated This method is deprecated. Please use
150-
/// @ref SendEmailVerificationBeforeUpdatingEmailAsync(string) instead.
151-
///
152-
/// Sets the email address for the user.
153-
///
154-
/// May fail if there is already an email/password-based account for the same
155-
/// email address.
156-
[System.Obsolete("Please use `Task SendEmailVerificationBeforeUpdatingEmailAsync(string)` instead", false)]
157-
public Task UpdateEmailAsync(string email) {
158-
return GetValidFirebaseUserInternal().UpdateEmailAsync(email);
159-
}
160-
161149
/// Attempts to change the password for the current user.
162150
///
163151
/// For an account linked to an Identity Provider (IDP) with no password,

docs/readme.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,14 @@ Support
110110

111111
Release Notes
112112
-------------
113+
### Upcoming
114+
- Changes
115+
- Analytics: Removed deprecated `FirebaseAnalytics.ParameterGroupId`
116+
and `Parameter.Dispose` methods.
117+
- Auth: Removed deprecated `FirebaseUser.UpdateEmailAsync`.
118+
- Messaging: Removed deprecated `FirebaseMessage.Dispose`,
119+
`FirebaseNotification.Dispose`, and `MessagingOptions.Dispose` methods.
120+
113121
### 12.10.1
114122
- Changes
115123
- General (iOS): Change AppDelegate swizzling logic to not use `objc_copyClassList`,

messaging/src/FirebaseMessage.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,6 @@ internal static FirebaseMessage FromInternal(FirebaseMessageInternal other) {
104104
/// For example it can be a registration token, a topic name, a IID or project
105105
/// ID.
106106
public string To { get; private set; }
107-
108-
/// @deprecated No longer needed, will be removed in the future.
109-
[System.Obsolete("No longer needed, will be removed in the future.")]
110-
public void Dispose() { }
111-
112-
/// @deprecated No longer needed, will be removed in the future.
113-
[System.Obsolete("No longer needed, will be removed in the future.")]
114-
public void Dispose(bool disposing) { }
115107
}
116108

117109
} // namespace Firebase.Messaging

messaging/src/FirebaseNotification.cs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,6 @@ internal static AndroidNotificationParams FromInternal(AndroidNotificationParams
3131

3232
/// The channel id that was provided when the message was sent.
3333
public string ChannelId { get; private set; }
34-
35-
/// @deprecated No longer needed, will be removed in the future.
36-
[System.Obsolete("No longer needed, will be removed in the future.")]
37-
public void Dispose() { }
38-
39-
/// @deprecated No longer needed, will be removed in the future.
40-
[System.Obsolete("No longer needed, will be removed in the future.")]
41-
public void Dispose(bool disposing) { }
4234
}
4335

4436
/// Used for messages that display a notification.
@@ -151,14 +143,6 @@ internal static FirebaseNotification FromInternal(FirebaseNotificationInternal o
151143
/// On Android, use the key in the app's string resources when populating this
152144
/// value.
153145
public string TitleLocalizationKey { get; private set; }
154-
155-
/// @deprecated No longer needed, will be removed in the future.
156-
[System.Obsolete("No longer needed, will be removed in the future.")]
157-
public void Dispose() { }
158-
159-
/// @deprecated No longer needed, will be removed in the future.
160-
[System.Obsolete("No longer needed, will be removed in the future.")]
161-
public void Dispose(bool disposing) { }
162146
}
163147

164148
} // namespace Firebase.Messaging

messaging/src/MessagingOptions.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,6 @@ public MessagingOptions() { }
2626
public bool SuppressNotificationPermissionPrompt {
2727
get; set;
2828
}
29-
30-
/// @deprecated No longer needed, will be removed in the future.
31-
[System.Obsolete("No longer needed, will be removed in the future.")]
32-
public void Dispose() { }
33-
34-
/// @deprecated No longer needed, will be removed in the future.
35-
[System.Obsolete("No longer needed, will be removed in the future.")]
36-
public void Dispose(bool disposing) { }
3729
}
3830

3931
} // namespace Firebase.Messaging

0 commit comments

Comments
 (0)