Skip to content

Commit e85fbac

Browse files
committed
refactor(app_check): rename iosDebugToken to appleDebugToken
1 parent 6acdae5 commit e85fbac

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

packages/firebase_app_check/firebase_app_check/ios/firebase_app_check/Sources/firebase_app_check/FLTFirebaseAppCheckPlugin.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)flutter
123123
- (void)activate:(id)arguments withMethodCallResult:(FLTFirebaseMethodCallResult *)result {
124124
NSString *appNameDart = arguments[@"appName"];
125125
NSString *providerName = arguments[@"appleProvider"];
126-
NSString *debugToken = arguments[@"iosDebugToken"];
126+
NSString *debugToken = arguments[@"appleDebugToken"];
127127

128128
FIRApp *app = [FLTFirebasePlugin firebaseAppNamed:appNameDart];
129129
[self->providerFactory configure:app providerName:providerName debugToken:debugToken];

packages/firebase_app_check/firebase_app_check/lib/src/firebase_app_check.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -55,23 +55,23 @@ class FirebaseAppCheck extends FirebasePluginPlatform {
5555
/// On iOS or macOS, the default provider is "device check". If you wish to set the provider to "app attest", "debug" or "app attest with fallback to device check"
5656
/// ("app attest" is only available on iOS 14.0+, macOS 14.0+), you may set the `appleProvider` property using the `AppleProvider` enum
5757
///
58-
/// `androidDebugToken` and `iosDebugToken` allow you to set a debug token for the "debug" provider on Android and iOS respectively.
59-
/// On iOS you have to rerun app after changing `iosDebugToken`.
58+
/// `androidDebugToken` and `appleDebugToken` allow you to set a debug token for the "debug" provider on Android and Apple's systems, respectively.
59+
/// On iOS, you must restart the app after changing the appleDebugToken.
6060
///
6161
/// For more information, see [the Firebase Documentation](https://firebase.google.com/docs/app-check)
6262
Future<void> activate({
6363
WebProvider? webProvider,
6464
AndroidProvider androidProvider = AndroidProvider.playIntegrity,
6565
AppleProvider appleProvider = AppleProvider.deviceCheck,
6666
String? androidDebugToken,
67-
String? iosDebugToken,
67+
String? appleDebugToken,
6868
}) {
6969
return _delegate.activate(
7070
webProvider: webProvider,
7171
androidProvider: androidProvider,
7272
appleProvider: appleProvider,
7373
androidDebugToken: androidDebugToken,
74-
iosDebugToken: iosDebugToken,
74+
appleDebugToken: appleDebugToken,
7575
);
7676
}
7777

packages/firebase_app_check/firebase_app_check_platform_interface/lib/src/method_channel/method_channel_firebase_app_check.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class MethodChannelFirebaseAppCheck extends FirebaseAppCheckPlatform {
7979
AndroidProvider? androidProvider,
8080
AppleProvider? appleProvider,
8181
String? androidDebugToken,
82-
String? iosDebugToken,
82+
String? appleDebugToken,
8383
}) async {
8484
try {
8585
await channel.invokeMethod<void>('FirebaseAppCheck#activate', {
@@ -93,8 +93,8 @@ class MethodChannelFirebaseAppCheck extends FirebaseAppCheckPlatform {
9393
defaultTargetPlatform == TargetPlatform.macOS ||
9494
kDebugMode)
9595
'appleProvider': getAppleProviderString(appleProvider),
96-
if(iosDebugToken != null)
97-
'iosDebugToken': iosDebugToken,
96+
if(appleDebugToken != null)
97+
'appleDebugToken': appleDebugToken,
9898
});
9999
} on PlatformException catch (e, s) {
100100
convertPlatformException(e, s);

packages/firebase_app_check/firebase_app_check_platform_interface/lib/src/platform_interface/platform_interface_firebase_app_check.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ abstract class FirebaseAppCheckPlatform extends PlatformInterface {
6767
AndroidProvider? androidProvider,
6868
AppleProvider? appleProvider,
6969
String? androidDebugToken,
70-
String? iosDebugToken,
70+
String? appleDebugToken,
7171
}) {
7272
throw UnimplementedError('activate() is not implemented');
7373
}

tests/integration_test/firebase_app_check/firebase_app_check_e2e_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ void main() {
9999
() async {
100100
await expectLater(
101101
FirebaseAppCheck.instance.activate(
102-
iosDebugToken: 'debug_token',
102+
appleDebugToken: 'debug_token',
103103
appleProvider: AppleProvider.debug,
104104
),
105105
completes,

0 commit comments

Comments
 (0)