Skip to content

Commit 43e0bea

Browse files
committed
update kernel configs, make kernel in integ test
in upgrading to firecracker v1.1, we noticed some configuration options prompted for using when `make kernel`. These options are specific to kernel 4.14. Additionally, this upgrade changed the build output from firecracker's devtool to exclude the full kernel version (i.e. w/o the patch number). This PR also updates the integ test Docker image to use a freshly built kernel such that FUSE is enabled. Signed-off-by: Gavin Inglis <[email protected]>
1 parent 22e72b2 commit 43e0bea

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ KERNEL_CONFIG=tools/kernel-configs/microvm-kernel-$(host_arch)-$(KERNEL_VERSION)
6060
# Copied from https://github.com/firecracker-microvm/firecracker/blob/v1.0.0/tools/devtool#L2015
6161
# This allows us to specify a kernel without the patch version, but still get the correct build path to reference the kernel binary
6262
KERNEL_FULL_VERSION=$(shell cat "$(KERNEL_CONFIG)" | grep -Po "^\# Linux\/$(kernel_config_pattern) (([0-9]+.){2}[0-9]+)" | cut -d ' ' -f 3)
63-
KERNEL_BIN=$(FIRECRACKER_DIR)/build/kernel/linux-$(KERNEL_FULL_VERSION)/vmlinux-$(KERNEL_FULL_VERSION)-$(host_arch).bin
63+
KERNEL_BIN=$(FIRECRACKER_DIR)/build/kernel/linux-$(KERNEL_VERSION)/vmlinux-$(KERNEL_VERSION)-$(host_arch).bin
6464

6565
RUNC_DIR=$(SUBMODULES)/runc
6666
RUNC_BIN=$(RUNC_DIR)/runc
@@ -190,7 +190,7 @@ test-images: test-images-stamp
190190
test-images-stamp: | image firecracker-containerd-test-image
191191
touch $@
192192

193-
firecracker-containerd-test-image: all-in-docker firecracker runc test-cni-bins cni-bins default-vmlinux
193+
firecracker-containerd-test-image: all-in-docker firecracker runc test-cni-bins cni-bins default-vmlinux kernel
194194
DOCKER_BUILDKIT=1 docker build \
195195
--progress=plain \
196196
--file tools/docker/Dockerfile.integ-test \

tools/docker/Dockerfile.integ-test

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ RUN --mount=type=bind,target=/src make -C /src \
6161
install \
6262
install-firecracker \
6363
install-runc \
64-
install-default-vmlinux \
64+
install-kernel \
6565
install-default-rootfs \
6666
install-default-runc-jailer-config \
6767
install-test-cni-bins \

tools/kernel-configs/microvm-kernel-aarch64-4.14.config

+1
Original file line numberDiff line numberDiff line change
@@ -1123,6 +1123,7 @@ CONFIG_VIRTIO_BLK=y
11231123
# CONFIG_ENCLOSURE_SERVICES is not set
11241124
# CONFIG_SRAM is not set
11251125
# CONFIG_C2PORT is not set
1126+
# CONFIG_R3964 is not set
11261127

11271128
#
11281129
# EEPROM support

tools/kernel-configs/microvm-kernel-x86_64-4.14.config

+5-2
Original file line numberDiff line numberDiff line change
@@ -1208,6 +1208,7 @@ CONFIG_VIRTIO_BLK=y
12081208
# CONFIG_ENCLOSURE_SERVICES is not set
12091209
# CONFIG_SRAM is not set
12101210
# CONFIG_C2PORT is not set
1211+
# CONFIG_R3964 is not set
12111212

12121213
#
12131214
# EEPROM support
@@ -2077,6 +2078,7 @@ CONFIG_DEBUG_KERNEL=y
20772078
# CONFIG_SLUB_STATS is not set
20782079
CONFIG_HAVE_DEBUG_KMEMLEAK=y
20792080
# CONFIG_DEBUG_KMEMLEAK is not set
2081+
# CONFIG_KMEMCHECK is not set
20802082
# CONFIG_DEBUG_STACK_USAGE is not set
20812083
# CONFIG_DEBUG_VM is not set
20822084
CONFIG_ARCH_HAS_DEBUG_VIRTUAL=y
@@ -2225,8 +2227,8 @@ CONFIG_OPTIMIZE_INLINING=y
22252227
# CONFIG_DEBUG_ENTRY is not set
22262228
# CONFIG_DEBUG_NMI_SELFTEST is not set
22272229
# CONFIG_X86_DEBUG_FPU is not set
2228-
# CONFIG_UNWINDER_ORC is not set
2229-
CONFIG_UNWINDER_FRAME_POINTER=y
2230+
# CONFIG_ORC_UNWINDER is not set
2231+
CONFIG_FRAME_POINTER_UNWINDER=y
22302232

22312233
#
22322234
# Security options
@@ -2394,6 +2396,7 @@ CONFIG_CRYPTO_AES_TI=y
23942396
# CONFIG_CRYPTO_FCRYPT is not set
23952397
# CONFIG_CRYPTO_KHAZAD is not set
23962398
# CONFIG_CRYPTO_SALSA20 is not set
2399+
# CONFIG_CRYPTO_SALSA20_X86_64 is not set
23972400
# CONFIG_CRYPTO_CHACHA20 is not set
23982401
# CONFIG_CRYPTO_CHACHA20_X86_64 is not set
23992402
# CONFIG_CRYPTO_SEED is not set

0 commit comments

Comments
 (0)