Skip to content

Commit 56568de

Browse files
committed
Fetch 30 commits just in case to correctly check 20 commits
git-validation doesn't check Signed-off-by: line (aka DCO) in merge commits. However, apparently Git cannot recognize merge commits when one of the parents is missing. This change fetches 30 commites instead of 21 just in case to make sure we fetch merge commits with the associated parents. Signed-off-by: Kazuyoshi Kato <[email protected]>
1 parent cc86796 commit 56568de

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/build.yaml

+5-3
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,11 @@ jobs:
3333
# While DCO check (on Makefile) checks latest 20 commits,
3434
# the checkout action automatically creates a merge commit
3535
# for merging "master" into a pull request branch.
36-
# So we need to fetch 21 commits (including the merge commit)
37-
# to have 20 actual commits from a pull request.
38-
fetch-depth: 21
36+
# In addition to that, Git cannot recognize merge commits when
37+
# one of the parents is missing.
38+
# So, we will fetch 30 commits just in case to have
39+
# 20 actual commits with associated merged commits.
40+
fetch-depth: 30
3941
- uses: actions/setup-go@v1
4042
with:
4143
go-version: ${{ matrix.go }}

0 commit comments

Comments
 (0)