Bump Go min version to Go 1.23 (#805)

* Bump Go min version to Go 1.23

Signed-off-by: Austin Vazquez <[email protected]>

* Resolve lint warnings for golangci-lint v1.64.2

Signed-off-by: Austin Vazquez <[email protected]>

---------

Signed-off-by: Austin Vazquez <[email protected]>

Author: austinvazquez

.github/workflows/build.yaml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       matrix:
         os: ['ubuntu-20.04', 'ubuntu-22.04']
-        go: ['1.21', '1.22']
+        go: ['1.23', '1.24']
       # Build all variants regardless of failures
       fail-fast: false
 

.golangci.yml

@@ -5,8 +5,8 @@ linters:
   disable-all: true
   enable:
     - govet
+    - copyloopvar
     - staticcheck
-#    - unused
     - gosimple
     - ineffassign
     - typecheck
@@ -19,15 +19,29 @@ linters:
     - gocritic
     - gofmt
     - revive
-    - exportloopref
 
 issues:
   exclude-use-default: false
   exclude:
     - G104 # Errors unhandled
     - G103 # Use of unsafe calls should be audited
+    - G114 # Use of net/http serve function without timeouts.
+    - G115 # Integer overflow conversion should be audited
     - G204 # Subprocess launched with variable
+    - G301 # Expect directory permissions to be 0750 or less
     - G304 # Potential file inclusion via variable
     - G306 # WriteFile permissions 0600 or less to be audited
     - G307 # Deferring unsafe method "Close" on type "*os.File" to be audited
-    - 
+    - G404 # Use of weak random number generator
+  exclude-rules:
+    - linters:
+      - govet
+      text: "copylocks"
+    - linters:
+      - revive
+      text: package-comments
+    - linters:
+      - staticcheck
+      text: "Do not rely on the global seed"
+  exclude-dirs:
+    - snapshotter/internal/integtest/stargz # Code copied from upstream stargz

Makefile

@@ -28,7 +28,7 @@ SUBMODULES=_submodules
 UID:=$(shell id -u)
 GID:=$(shell id -g)
 
-FIRECRACKER_CONTAINERD_BUILDER_IMAGE?=golang:1.21-bullseye
+FIRECRACKER_CONTAINERD_BUILDER_IMAGE?=golang:1.23-bullseye
 export FIRECRACKER_CONTAINERD_TEST_IMAGE?=localhost/firecracker-containerd-test
 export GO_CACHE_VOLUME_NAME?=gocache
 
@@ -136,7 +136,7 @@ tidy:
 	./tools/tidy.sh
 
 $(BINPATH)/golangci-lint:
-	GOBIN=$(BINPATH) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.57.2
+	GOBIN=$(BINPATH) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.2
 	$(BINPATH)/golangci-lint --version
 
 $(BINPATH)/git-validation:

agent/drive_handler.go

@@ -21,9 +21,9 @@ import (
 	"strings"
 	"time"
 
-	"github.com/containerd/containerd/log"
 	"github.com/containerd/containerd/mount"
 	"github.com/containerd/containerd/protobuf/types"
+	"github.com/containerd/log"
 	"github.com/firecracker-microvm/firecracker-containerd/internal"
 	drivemount "github.com/firecracker-microvm/firecracker-containerd/proto/service/drivemount/ttrpc"
 )
@@ -214,7 +214,7 @@ func (dh driveHandler) MountDrive(ctx context.Context, req *drivemount.MountDriv
 	return nil, fmt.Errorf("exhausted retries mounting drive from %q to %q", drive.Path(), req.DestinationPath)
 }
 
-func (dh driveHandler) UnmountDrive(ctx context.Context, req *drivemount.UnmountDriveRequest) (*types.Empty, error) {
+func (dh driveHandler) UnmountDrive(_ context.Context, req *drivemount.UnmountDriveRequest) (*types.Empty, error) {
 	drive, ok := dh.GetDrive(req.DriveID)
 	if !ok {
 		return nil, fmt.Errorf("drive %q could not be found", req.DriveID)

agent/error_test.go

@@ -55,7 +55,6 @@ func TestIsRetryableMountError(t *testing.T) {
 	}
 
 	for _, c := range cases {
-		c := c // see https://github.com/kyoh86/scopelint/issues/4
 		t.Run(c.Name, func(t *testing.T) {
 			assert.Equal(t, c.Expected, isRetryableMountError(c.Error))
 		})

agent/ioproxy_handler.go

@@ -17,8 +17,8 @@ import (
 	"context"
 
 	task "github.com/containerd/containerd/api/runtime/task/v2"
-	"github.com/containerd/containerd/log"
 	"github.com/containerd/containerd/protobuf/types"
+	"github.com/containerd/log"
 	"github.com/firecracker-microvm/firecracker-containerd/internal/vm"
 	ioproxy "github.com/firecracker-microvm/firecracker-containerd/proto/service/ioproxy/ttrpc"
 )

agent/main.go

@@ -23,9 +23,9 @@ import (
 
 	taskAPI "github.com/containerd/containerd/api/runtime/task/v2"
 	"github.com/containerd/containerd/events/exchange"
-	"github.com/containerd/containerd/log"
 	"github.com/containerd/containerd/namespaces"
 	"github.com/containerd/containerd/sys/reaper"
+	"github.com/containerd/log"
 	"github.com/containerd/ttrpc"
 	"github.com/firecracker-microvm/firecracker-go-sdk/vsock"
 	"github.com/opencontainers/runc/libcontainer/system"

agent/service.go

@@ -25,11 +25,11 @@ import (
 	taskAPI "github.com/containerd/containerd/api/runtime/task/v2"
 	"github.com/containerd/containerd/cio"
 	"github.com/containerd/containerd/identifiers"
-	"github.com/containerd/containerd/log"
 	"github.com/containerd/containerd/mount"
 	"github.com/containerd/containerd/protobuf/types"
 	runc "github.com/containerd/containerd/runtime/v2/runc/v2"
 	"github.com/containerd/containerd/runtime/v2/shim"
+	"github.com/containerd/log"
 	"github.com/hashicorp/go-multierror"
 	"github.com/sirupsen/logrus"
 	"golang.org/x/sys/unix"

docs/getting-started.md

@@ -40,7 +40,7 @@ You need to have the following things in order to use firecracker-containerd:
 * git
 * gcc, required by the Firecracker agent for building
 * A recent installation of [Docker CE](https://docker.com).
-* Go 1.21 or later, which you can download from [here](https://golang.org/dl/).
+* Go 1.23 or later, which you can download from [here](https://golang.org/dl/).
 
 ## Setup
 

docs/quickstart.md

@@ -28,14 +28,14 @@ files into `/usr/local/bin`.
 
 cd ~
 
-# Install git, Go 1.21, make, curl
+# Install git, Go 1.23, make, curl
 sudo mkdir -p /etc/apt/sources.list.d
 echo "deb http://ftp.debian.org/debian bullseye-backports main" | \
   sudo tee /etc/apt/sources.list.d/bullseye-backports.list
 sudo DEBIAN_FRONTEND=noninteractive apt-get update
 sudo DEBIAN_FRONTEND=noninteractive apt-get \
   install --yes \
-  golang-1.21 \
+  golang-1.23 \
   make \
   git \
   curl \
@@ -44,8 +44,8 @@ sudo DEBIAN_FRONTEND=noninteractive apt-get \
   bc \
   gnupg
 
-# Debian's Go 1.21 package installs "go" command under /usr/lib/go-1.21/bin
-export PATH=/usr/lib/go-1.21/bin:$PATH
+# Debian's Go 1.23 package installs "go" command under /usr/lib/go-1.23/bin
+export PATH=/usr/lib/go-1.23/bin:$PATH
 
 cd ~
 
@@ -93,7 +93,7 @@ sudo yum -y install \
 # need to source environment variables afterwards for the existing shell session.
 curl -LO https://get.golang.org/$(uname)/go_installer && \
   chmod +x go_installer && \
-  ./go_installer -version 1.21 && \
+  ./go_installer -version 1.23 && \
   rm go_installer && \
   source .bash_profile