Remove unused tiles.bundle.request_timeout config

(for now)

Author: riptl

src/app/fdctl/config/default.toml

@@ -1162,12 +1162,6 @@ dynamic_port_range = "8900-9000"
         # [3e3,3600e3]
         keepalive_interval_millis = 5000
 
-        # Consider a connection failed if the bundle server fails to
-        # respond to a request in the given time frame.  The validator
-        # will reconnect eventually, but with increasing delays if there
-        # are repeated failures.  Must be within range [500,60000].
-        request_timeout_millis = 3000
-
     # The pack tile takes incoming transactions that have been verified
     # by the verify tile and then deduplicated, and attempts to order
     # them in an optimal way to generate the most fees per compute

src/app/fdctl/topology.c

@@ -386,8 +386,7 @@ fd_topo_initialize( config_t * config ) {
       strncpy( tile->bundle.key_log_path, config->development.bundle.ssl_key_log_file, sizeof(tile->bundle.key_log_path) );
       tile->bundle.buf_sz = config->development.bundle.buffer_size_kib<<10;
       tile->bundle.ssl_heap_sz = config->development.bundle.ssl_heap_size_mib<<20;
-      tile->bundle.keepalive_interval_nanos = (ulong)( (float)config->tiles.bundle.keepalive_interval_millis * 1e6f );
-      tile->bundle.request_timeout_nanos = (ulong)( (float)config->tiles.bundle.request_timeout_millis * 1e6f );
+      tile->bundle.keepalive_interval_nanos = config->tiles.bundle.keepalive_interval_millis * (ulong)1e6;
     } else if( FD_UNLIKELY( !strcmp( tile->name, "verify" ) ) ) {
       tile->verify.tcache_depth = config->tiles.verify.signature_cache_size;
 

src/app/firedancer/config/default.toml

@@ -867,12 +867,6 @@ user = ""
         # [3e3,3600e3]
         keepalive_interval_millis = 5000
 
-        # Consider a connection failed if the bundle server fails to
-        # respond to a request in the given time frame.  The validator
-        # will reconnect eventually, but with increasing delays if there
-        # are repeated failures.  Must be within range [500,60000].
-        request_timeout_millis = 3000
-
     # The pack tile takes incoming transactions that have been verified
     # by the verify tile and then deduplicated, and attempts to order
     # them in an optimal way to generate the most fees per compute

src/app/shared/fd_config.c

@@ -527,10 +527,6 @@ fd_config_validate( fd_config_t const * config ) {
                    config->tiles.bundle.keepalive_interval_millis > 3600000 ) ) {
     FD_LOG_ERR(( "`tiles.bundle.keepalive_interval_millis` must be in range [3000, 3,600,000]" ));
   }
-  if( FD_UNLIKELY( config->tiles.bundle.request_timeout_millis <   500 &&
-                   config->tiles.bundle.request_timeout_millis > 60000 ) ) {
-    FD_LOG_ERR(( "`tiles.bundle.request_timeout_millis` must be in range [500, 60,000]" ));
-  }
 
   CFG_HAS_NON_EMPTY( development.netns.interface0 );
   CFG_HAS_NON_EMPTY( development.netns.interface0_mac );

src/app/shared/fd_config.h

@@ -336,7 +336,6 @@ struct fd_config {
       char tip_distribution_authority[ FD_BASE58_ENCODED_32_SZ ];
       uint commission_bps;
       ulong keepalive_interval_millis;
-      ulong request_timeout_millis;
     } bundle;
 
     struct {

src/app/shared/fd_config_parse.c

@@ -189,7 +189,6 @@ fd_config_extract_pod( uchar *       pod,
   CFG_POP      ( cstr,   tiles.bundle.tip_distribution_authority          );
   CFG_POP      ( uint,   tiles.bundle.commission_bps                      );
   CFG_POP      ( ulong,  tiles.bundle.keepalive_interval_millis           );
-  CFG_POP      ( ulong,  tiles.bundle.request_timeout_millis              );
 
   CFG_POP      ( uint,   tiles.pack.max_pending_transactions              );
   CFG_POP      ( bool,   tiles.pack.use_consumed_cus                      );

src/app/shared_dev/commands/bundle_client.c

@@ -52,8 +52,7 @@ bundle_client_topo( config_t *   config ) {
   strncpy( bundle_tile->bundle.key_log_path, config->development.bundle.ssl_key_log_file, sizeof(bundle_tile->bundle.key_log_path) );
   bundle_tile->bundle.buf_sz = config->development.bundle.buffer_size_kib<<10;
   bundle_tile->bundle.ssl_heap_sz = config->development.bundle.ssl_heap_size_mib<<20;
-  bundle_tile->bundle.keepalive_interval_nanos = (ulong)( (float)config->tiles.bundle.keepalive_interval_millis * 1e6f );
-  bundle_tile->bundle.request_timeout_nanos = (ulong)( (float)config->tiles.bundle.request_timeout_millis * 1e6f );
+  bundle_tile->bundle.keepalive_interval_nanos = config->tiles.bundle.keepalive_interval_millis * (ulong)1e6;
 
   strncpy( sign_tile->sign.identity_key_path, config->paths.identity_key, sizeof(sign_tile->sign.identity_key_path) );
 

src/disco/topo/fd_topo.h

@@ -200,7 +200,6 @@ typedef struct {
       ulong buf_sz;
       ulong ssl_heap_sz;
       ulong keepalive_interval_nanos;
-      ulong request_timeout_nanos;
     } bundle;
 
     struct {