Skip to content

Commit b468b00

Browse files
fishercoder1534fishercoder1534
committed
checkstyle fix
1 parent 966d501 commit b468b00

File tree

2 files changed

+192
-185
lines changed

2 files changed

+192
-185
lines changed

‎fishercoder_codestyle.xml

+184-182
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0"?>
22
<!DOCTYPE module PUBLIC
3-
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
4-
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
3+
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
4+
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
55

66
<!--
77
@@ -21,189 +21,191 @@
2121
2222
-->
2323

24-
<module name = "Checker">
25-
<property name="charset" value="UTF-8"/>
24+
<module name="Checker">
25+
<property name="charset" value="UTF-8"/>
2626

27-
<property name="severity" value="error"/>
27+
<property name="severity" value="error"/>
2828

29-
<!-- Checks for whitespace -->
30-
<!-- See http://checkstyle.sf.net/config_whitespace.html -->
31-
<!--<module name="FileTabCharacter">
32-
<property name="eachLine" value="false"/>
33-
</module>-->
34-
35-
<module name="SuppressionCommentFilter">
36-
<property name="offCommentFormat" value="CHECKSTYLE_OFF\: ([\w\|]+)"/>
37-
<property name="onCommentFormat" value="CHECKSTYLE_OFF\: ([\w\|]+)"/>
38-
<property name="checkFormat" value="$1"/>
39-
</module>
40-
41-
<module name="TreeWalker">
42-
<property name="tabWidth" value="4"/>
43-
<module name="OuterTypeFilename"/>
44-
<!--<module name="IllegalTokenText">
45-
<property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
46-
<property name="format" value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
47-
<property name="message" value="Avoid using corresponding octal or Unicode escape."/>
48-
</module>
49-
<module name="AvoidEscapedUnicodeCharacters">
50-
<property name="allowEscapesForControlCharacters" value="true"/>
51-
<property name="allowByTailComment" value="true"/>
52-
<property name="allowNonPrintableEscapes" value="true"/>
53-
</module> -->
54-
<module name="LineLength">
55-
<!--change it to 100 later-->
56-
<property name="max" value="1000"/>
57-
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
58-
</module>
59-
<!-- <module name="AvoidStarImport"/> -->
60-
<module name="OneTopLevelClass"/>
61-
<!--<module name="NoLineWrap"/>-->
62-
<module name="EmptyBlock">
63-
<property name="option" value="TEXT"/>
64-
<property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
65-
</module>
66-
<!--<module name="NeedBraces"/>-->
67-
<!--<module name="LeftCurly">-->
68-
<!--<property name="maxLineLength" value="100"/>-->
69-
<!--</module>-->
70-
<module name="RightCurly"/>
71-
<module name="RightCurly">
72-
<property name="option" value="alone"/>
73-
<property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
74-
</module>
75-
<module name="WhitespaceAround">
76-
<property name="allowEmptyConstructors" value="true"/>
77-
<property name="allowEmptyMethods" value="true"/>
78-
<property name="allowEmptyTypes" value="true"/>
79-
<property name="allowEmptyLoops" value="true"/>
80-
<message key="ws.notFollowed"
81-
value="WhitespaceAround: ''{0}'' is not followed by whitespace."/>
82-
<message key="ws.notPreceded"
83-
value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
84-
</module>
85-
<!--<module name="OneStatementPerLine"/>-->
86-
<module name="MultipleVariableDeclarations"/>
87-
<module name="ArrayTypeStyle"/>
88-
<module name="MissingSwitchDefault"/>
89-
<module name="FallThrough"/>
90-
<module name="UpperEll"/>
91-
<module name="ModifierOrder"/>
92-
<module name="EmptyLineSeparator">
93-
<property name="allowNoEmptyLineBetweenFields" value="true"/>
94-
</module>
95-
<module name="SeparatorWrap">
96-
<property name="tokens" value="DOT"/>
97-
<property name="option" value="nl"/>
98-
</module>
99-
<module name="SeparatorWrap">
100-
<property name="tokens" value="COMMA"/>
101-
<property name="option" value="EOL"/>
102-
</module>
103-
<module name="PackageName">
104-
<property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
105-
<message key="name.invalidPattern"
106-
value="Package name ''{0}'' must match pattern ''{1}''."/>
107-
</module>
108-
<module name="TypeName">
109-
<message key="name.invalidPattern"
110-
value="Type name ''{0}'' must match pattern ''{1}''."/>
111-
</module>
112-
<!--<module name="MemberName">-->
113-
<!--<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>-->
114-
<!--<message key="name.invalidPattern"-->
115-
<!--value="Member name ''{0}'' must match pattern ''{1}''."/>-->
116-
<!--</module>-->
117-
<module name="ParameterName">
118-
<property name="format" value="^[a-z][a-zA-Z0-9]*$"/>
119-
<message key="name.invalidPattern"
120-
value="Parameter name ''{0}'' must match pattern ''{1}''."/>
121-
</module>
122-
<module name="LocalVariableName">
123-
<property name="tokens" value="VARIABLE_DEF"/>
124-
<property name="format" value="^[a-z][a-zA-Z0-9]*$"/>
125-
<property name="allowOneCharVarInForLoop" value="true"/>
126-
<message key="name.invalidPattern"
127-
value="Local variable name ''{0}'' must match pattern ''{1}''."/>
128-
</module>
129-
<module name="ClassTypeParameterName">
130-
<property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
131-
<message key="name.invalidPattern"
132-
value="Class type name ''{0}'' must match pattern ''{1}''."/>
133-
</module>
134-
<module name="MethodTypeParameterName">
135-
<property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
136-
<message key="name.invalidPattern"
137-
value="Method type name ''{0}'' must match pattern ''{1}''."/>
138-
</module>
139-
<module name="NoFinalizer"/>
140-
<module name="GenericWhitespace">
141-
<message key="ws.followed"
142-
value="GenericWhitespace ''{0}'' is followed by whitespace."/>
143-
<message key="ws.preceded"
144-
value="GenericWhitespace ''{0}'' is preceded with whitespace."/>
145-
<message key="ws.illegalFollow"
146-
value="GenericWhitespace ''{0}'' should followed by whitespace."/>
147-
<message key="ws.notPreceded"
148-
value="GenericWhitespace ''{0}'' is not preceded with whitespace."/>
149-
</module>
150-
<!--<module name="Indentation">
151-
<property name="basicOffset" value="4"/>
152-
<property name="braceAdjustment" value="0"/>
153-
<property name="caseIndent" value="4"/>
154-
<property name="throwsIndent" value="4"/>
155-
<property name="lineWrappingIndentation" value="4"/>
156-
<property name="arrayInitIndent" value="4"/>
29+
<!-- Checks for whitespace -->
30+
<!-- See http://checkstyle.sf.net/config_whitespace.html -->
31+
<!--<module name="FileTabCharacter">
32+
<property name="eachLine" value="false"/>
15733
</module>-->
158-
<module name="AbbreviationAsWordInName">
159-
<property name="ignoreFinal" value="false"/>
160-
<property name="allowedAbbreviationLength" value="1"/>
161-
</module>
162-
<!--<module name="OverloadMethodsDeclarationOrder"/>-->
163-
<module name="VariableDeclarationUsageDistance">
164-
<property name="allowedDistance" value="20"/>
165-
</module>
166-
<module name="MethodParamPad"/>
167-
<module name="OperatorWrap">
168-
<property name="option" value="NL"/>
169-
<property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
170-
</module>
171-
<!--<module name="AnnotationLocation">
172-
<property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF"/>
173-
</module>
174-
<module name="AnnotationLocation">
175-
<property name="tokens" value="VARIABLE_DEF"/>
176-
<property name="allowSamelineMultipleAnnotations" value="true"/>
177-
</module>
178-
<module name="NonEmptyAtclauseDescription"/>
179-
<module name="JavadocTagContinuationIndentation"/>
180-
<module name="SummaryJavadocCheck">
181-
<property name="forbiddenSummaryFragments" value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/>
182-
</module>
183-
<module name="JavadocParagraph"/>
184-
<module name="AtclauseOrder">
185-
<property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
186-
<property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
187-
</module>
188-
<module name="JavadocMethod">
189-
<property name="scope" value="public"/>
190-
<property name="allowMissingParamTags" value="true"/>
191-
<property name="allowMissingThrowsTags" value="true"/>
192-
<property name="allowMissingReturnTag" value="true"/>
193-
<property name="minLineCount" value="2"/>
194-
<property name="allowedAnnotations" value="Override, Test"/>
195-
<property name="allowThrowsTagsForSubclasses" value="true"/>
196-
</module>-->
197-
<module name="MethodName">
198-
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
199-
<message key="name.invalidPattern"
200-
value="Method name ''{0}'' must match pattern ''{1}''."/>
34+
35+
<module name="SuppressionCommentFilter">
36+
<property name="offCommentFormat" value="CHECKSTYLE_OFF\: ([\w\|]+)"/>
37+
<property name="onCommentFormat" value="CHECKSTYLE_OFF\: ([\w\|]+)"/>
38+
<property name="checkFormat" value="$1"/>
20139
</module>
202-
<module name="MethodLength">
203-
<property name="tokens" value="METHOD_DEF"/>
204-
<property name="max" value="100"/>
205-
<property name="countEmpty" value="false"/>
40+
41+
<module name="TreeWalker">
42+
<property name="tabWidth" value="4"/>
43+
<module name="OuterTypeFilename"/>
44+
<!--<module name="IllegalTokenText">
45+
<property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
46+
<property name="format" value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
47+
<property name="message" value="Avoid using corresponding octal or Unicode escape."/>
48+
</module>
49+
<module name="AvoidEscapedUnicodeCharacters">
50+
<property name="allowEscapesForControlCharacters" value="true"/>
51+
<property name="allowByTailComment" value="true"/>
52+
<property name="allowNonPrintableEscapes" value="true"/>
53+
</module> -->
54+
<module name="LineLength">
55+
<!--change it to 100 later-->
56+
<property name="max" value="1000"/>
57+
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
58+
</module>
59+
<!-- <module name="AvoidStarImport"/> -->
60+
<module name="OneTopLevelClass"/>
61+
<!--<module name="NoLineWrap"/>-->
62+
<module name="EmptyBlock">
63+
<property name="option" value="TEXT"/>
64+
<property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
65+
</module>
66+
<!--<module name="NeedBraces"/>-->
67+
<!--<module name="LeftCurly">-->
68+
<!--<property name="maxLineLength" value="100"/>-->
69+
<!--</module>-->
70+
<module name="RightCurly"/>
71+
<module name="RightCurly">
72+
<property name="option" value="alone"/>
73+
<property name="tokens"
74+
value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
75+
</module>
76+
<!--<module name="WhitespaceAround">-->
77+
<!--<property name="allowEmptyConstructors" value="true"/>-->
78+
<!--<property name="allowEmptyMethods" value="true"/>-->
79+
<!--<property name="allowEmptyTypes" value="true"/>-->
80+
<!--<property name="allowEmptyLoops" value="true"/>-->
81+
<!--<message key="ws.notFollowed"-->
82+
<!--value="WhitespaceAround: ''{0}'' is not followed by whitespace."/>-->
83+
<!--<message key="ws.notPreceded"-->
84+
<!--value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>-->
85+
<!--</module>-->
86+
<!--<module name="OneStatementPerLine"/>-->
87+
<module name="MultipleVariableDeclarations"/>
88+
<module name="ArrayTypeStyle"/>
89+
<module name="MissingSwitchDefault"/>
90+
<module name="FallThrough"/>
91+
<module name="UpperEll"/>
92+
<module name="ModifierOrder"/>
93+
<module name="EmptyLineSeparator">
94+
<property name="allowNoEmptyLineBetweenFields" value="true"/>
95+
</module>
96+
<module name="SeparatorWrap">
97+
<property name="tokens" value="DOT"/>
98+
<property name="option" value="nl"/>
99+
</module>
100+
<module name="SeparatorWrap">
101+
<property name="tokens" value="COMMA"/>
102+
<property name="option" value="EOL"/>
103+
</module>
104+
<module name="PackageName">
105+
<property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
106+
<message key="name.invalidPattern"
107+
value="Package name ''{0}'' must match pattern ''{1}''."/>
108+
</module>
109+
<!--<module name="TypeName">-->
110+
<!--<message key="name.invalidPattern"-->
111+
<!--value="Type name ''{0}'' must match pattern ''{1}''."/>-->
112+
<!--</module>-->
113+
<!--<module name="MemberName">-->
114+
<!--<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>-->
115+
<!--<message key="name.invalidPattern"-->
116+
<!--value="Member name ''{0}'' must match pattern ''{1}''."/>-->
117+
<!--</module>-->
118+
<!--<module name="ParameterName">-->
119+
<!--<property name="format" value="^[a-z][a-zA-Z0-9]*$"/>-->
120+
<!--<message key="name.invalidPattern"-->
121+
<!--value="Parameter name ''{0}'' must match pattern ''{1}''."/>-->
122+
<!--</module>-->
123+
<!--<module name="LocalVariableName">-->
124+
<!--<property name="tokens" value="VARIABLE_DEF"/>-->
125+
<!--<property name="format" value="^[a-z][a-zA-Z0-9]*$"/>-->
126+
<!--<property name="allowOneCharVarInForLoop" value="true"/>-->
127+
<!--<message key="name.invalidPattern"-->
128+
<!--value="Local variable name ''{0}'' must match pattern ''{1}''."/>-->
129+
<!--</module>-->
130+
<module name="ClassTypeParameterName">
131+
<property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
132+
<message key="name.invalidPattern"
133+
value="Class type name ''{0}'' must match pattern ''{1}''."/>
134+
</module>
135+
<module name="MethodTypeParameterName">
136+
<property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
137+
<message key="name.invalidPattern"
138+
value="Method type name ''{0}'' must match pattern ''{1}''."/>
139+
</module>
140+
<module name="NoFinalizer"/>
141+
<!--<module name="GenericWhitespace">-->
142+
<!--<message key="ws.followed"-->
143+
<!--value="GenericWhitespace ''{0}'' is followed by whitespace."/>-->
144+
<!--<message key="ws.preceded"-->
145+
<!--value="GenericWhitespace ''{0}'' is preceded with whitespace."/>-->
146+
<!--<message key="ws.illegalFollow"-->
147+
<!--value="GenericWhitespace ''{0}'' should followed by whitespace."/>-->
148+
<!--<message key="ws.notPreceded"-->
149+
<!--value="GenericWhitespace ''{0}'' is not preceded with whitespace."/>-->
150+
<!--</module>-->
151+
<!--<module name="Indentation">
152+
<property name="basicOffset" value="4"/>
153+
<property name="braceAdjustment" value="0"/>
154+
<property name="caseIndent" value="4"/>
155+
<property name="throwsIndent" value="4"/>
156+
<property name="lineWrappingIndentation" value="4"/>
157+
<property name="arrayInitIndent" value="4"/>
158+
</module>-->
159+
<module name="AbbreviationAsWordInName">
160+
<property name="ignoreFinal" value="false"/>
161+
<property name="allowedAbbreviationLength" value="10"/>
162+
</module>
163+
<!--<module name="OverloadMethodsDeclarationOrder"/>-->
164+
<module name="VariableDeclarationUsageDistance">
165+
<property name="allowedDistance" value="20"/>
166+
</module>
167+
<module name="MethodParamPad"/>
168+
<module name="OperatorWrap">
169+
<property name="option" value="NL"/>
170+
<property name="tokens"
171+
value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
172+
</module>
173+
<!--<module name="AnnotationLocation">
174+
<property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF"/>
175+
</module>
176+
<module name="AnnotationLocation">
177+
<property name="tokens" value="VARIABLE_DEF"/>
178+
<property name="allowSamelineMultipleAnnotations" value="true"/>
179+
</module>
180+
<module name="NonEmptyAtclauseDescription"/>
181+
<module name="JavadocTagContinuationIndentation"/>
182+
<module name="SummaryJavadocCheck">
183+
<property name="forbiddenSummaryFragments" value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/>
184+
</module>
185+
<module name="JavadocParagraph"/>
186+
<module name="AtclauseOrder">
187+
<property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
188+
<property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
189+
</module>
190+
<module name="JavadocMethod">
191+
<property name="scope" value="public"/>
192+
<property name="allowMissingParamTags" value="true"/>
193+
<property name="allowMissingThrowsTags" value="true"/>
194+
<property name="allowMissingReturnTag" value="true"/>
195+
<property name="minLineCount" value="2"/>
196+
<property name="allowedAnnotations" value="Override, Test"/>
197+
<property name="allowThrowsTagsForSubclasses" value="true"/>
198+
</module>-->
199+
<module name="MethodName">
200+
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
201+
<message key="name.invalidPattern"
202+
value="Method name ''{0}'' must match pattern ''{1}''."/>
203+
</module>
204+
<module name="MethodLength">
205+
<property name="tokens" value="METHOD_DEF"/>
206+
<property name="max" value="100"/>
207+
<property name="countEmpty" value="false"/>
208+
</module>
209+
<!--<module name="SingleLineJavadoc"/> -->
206210
</module>
207-
<!--<module name="SingleLineJavadoc"/> -->
208-
</module>
209211
</module>

‎src/main/java/com/fishercoder/solutions/_98.java

+8-3
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,14 @@ public boolean isValidBST(TreeNode root) {
5454
private boolean dfs(TreeNode root, long minValue, long maxValue) {
5555
if (root == null) return true;
5656
if (root != null && (root.val <= minValue || root.val >= maxValue)) return false;
57-
boolean leftResult = true, rightResult = true;
58-
if (root.left != null) leftResult = dfs(root.left, minValue, root.val);
59-
if (root.right != null) rightResult = dfs(root.right, root.val, maxValue);
57+
boolean leftResult = true;
58+
boolean rightResult = true;
59+
if (root.left != null) {
60+
leftResult = dfs(root.left, minValue, root.val);
61+
}
62+
if (root.right != null) {
63+
rightResult = dfs(root.right, root.val, maxValue);
64+
}
6065
return leftResult && rightResult;
6166
}
6267
}

0 commit comments

Comments
 (0)