Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#401 Binary Watch has an incorrect solution #38

Closed
jimsmithm3 opened this issue Mar 7, 2019 · 1 comment
Closed

#401 Binary Watch has an incorrect solution #38

jimsmithm3 opened this issue Mar 7, 2019 · 1 comment

Comments

@jimsmithm3
Copy link

When you run it against the provided test case it even fails

Input
1

Output
["0:01","0:02","0:04","0:08","0:16","0:32","1:04","2:08","4:16","8:32"]
Expected
["0:01","0:02","0:04","0:08","0:16","0:32","1:00","2:00","4:00","8:00"]

You can't treat hour like 60 minutes here, it's not a regular clock.

@fishercoder1534
Copy link
Owner

Great call! Thanks for pointing it out, I've fixed it and added a test to verify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants