UI bug: Light theme not toggling

[bouncepaw]

What I do:

• Visit any page on anagora.org
• Click the 🌙 button

What I expect:

• The light theme to turn on

What happens:

• Nothing, actually
• Well, the URL in the address bar gets # added to it

Environment:

• Safari Version 14.1.1 (16611.2.7.1.4)
• macOS 11.4 (20F71)

[bouncepaw]

Works in Opera, which is Chromium-based, on the same machine. This must be related to some novel API not supported by this Safari

[flancian]

Thank you for your structured report! I don't have a way to test Safari currently, but it seems likely you're right. I'll try to read about ways to do the theme switch which might be better supported. Weirdly enough, the code looks pretty straightforward: https://github.com/flancian/agora-server/blob/b52fedd398112237de7a597f0354bcfc09aaad04/app/js-src/main.ts#L43 It's just updating #theme-link. If cheap to do, it would be interesting to know whether you can see the DOM being updated in the browser inspector to point to the expected stylesheet on click, or whether the change doesn't happen at all.

…

On Thu, Apr 7, 2022 at 6:27 PM Timur Ismagilov ***@***.***> wrote: Works in Opera, which is Chromium-based, on the same machine. This must be related to some novel API not supported by this Safari — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN3RO3Z3GMC5RWH6TXHPQF3VD4EFHANCNFSM5SZ5T5WQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>