Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont use filesystem=host #1

Open
alexmo1997 opened this issue May 31, 2023 · 6 comments
Open

dont use filesystem=host #1

alexmo1997 opened this issue May 31, 2023 · 6 comments
Labels
requires upstream changes Requires upstream changes in a runtime, shared module, or Tenacity itself

Comments

@alexmo1997
Copy link

using filesystem=host is not really a good practices as it makes the flatpak sandbox irrelevant

@generic-pers0n
Copy link
Collaborator

As far as I can understand, this will likely cause problems for plugins. See flathub/org.audacityteam.Audacity#96 for more info.

@hfiguiere
Copy link
Contributor

nah home is enough for plugins. But Audacity was submitted with host permissions, before plugins were even possible.

@generic-pers0n
Copy link
Collaborator

Ah okay. Perhaps for a later release we can restrict this to home, then.

@TheEvilSkeleton
Copy link
Collaborator

My main concern is that there are many people who'd have files in external drives. Using home won't accommodate that use case.

@orowith2os
Copy link
Contributor

Maybe a closer look at Tenacity's plugins system is in question.

Flatpak has an extensions system built-in, ideally we'd rely on that. For external plugins, using the FileChooser portal should be enough, and the Documents portal will ensure we have access to them across app instances.

@generic-pers0n
Copy link
Collaborator

Regarding the usage of the FileChooser portal, I looked at wxWidgets's GTK file dialog implementation and it appears that it would require some reworking to use GtkFileChooserNative (or the GTK 4 equivalent). Therefore, it might be easier for Tenacity to use libportal directly.

@generic-pers0n generic-pers0n added the requires upstream changes Requires upstream changes in a runtime, shared module, or Tenacity itself label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires upstream changes Requires upstream changes in a runtime, shared module, or Tenacity itself
Projects
None yet
Development

No branches or pull requests

5 participants