To remove Counters from the main FleekERC721 contract #129
Replies: 4 comments 1 reply
-
I'm up to not use it if cleans up the code. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Decided to remove it per our discussion on Discord's daily sync. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Pull Request: #137 |
Beta Was this translation helpful? Give feedback.
1 reply
-
Update: Closing the discussion due to inactivity. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The only advantage that Counters brings to the contract over basic arithmetic is the checks it does on decrementation. Since the release of Solidity v0.8, the overflow checks have become part of the language itself.
There does not seem to be a reason to keep the library, especially because we don't decrement our counters ever in the contract.
Beta Was this translation helpful? Give feedback.
All reactions